[Pkg-puppet-devel] puppet-module-puppetlabs-stdlib ready for NEW-Queue

Thomas Bechtold thomasbechtold at jpberlin.de
Sun Sep 1 11:43:40 UTC 2013


On 09/01/2013 01:26 PM, Stig Sandbeck Mathisen wrote:
> Thomas Bechtold <thomasbechtold at jpberlin.de> writes:
> 
>> I'm fine with the changes and fixes! Can you push your changes to the
>> git repos, please?
> 
> Done. It also seems that puppet-common is not needed when building the
> package, so I removed that from Build-Depends as well.

Right. puppet-common was an artefact. I first tried to install the
module with "puppet module install ..." but that's no longer needed.

Two more things:
1) should the tests/ and spec/ directories be installed in
/usr/share/puppet/modules.available/puppetlabs-stdlib?

2) What about test execution during build?
We could do something like:

for F in `ls tests/` ; do puppet apply --modulepath=$PWD/../ --noop
tests/$F; done


I'm not sure if this is the correct way but seems that the files in
tests are intended to be used for smoke testing[1]. But I think the
tests shouldn't block an upload to the NEW queue.

Cheers,

Tom

[1] http://docs.puppetlabs.com/guides/tests_smoke.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-puppet-devel/attachments/20130901/e893399c/attachment.sig>


More information about the Pkg-puppet-devel mailing list