[Fwd: RFS: rutilt]

[Ben Hutchings]

On Mon, 2007-09-24 at 10:01 +0200, Cesare Tirabassi wrote:
> Ben Hutchings wrote:
> > On Wed, 2007-09-05 at 19:01 +0200, Cesare Tirabassi wrote:
> >   
> >> Could this package be of any interest to Debian?
> >> Perhaps somebody on this list could sponsor or review it?
> >>
> >> Many thanks in any case, and my apologies in advance if my email was not 
> >> appropriate.
> >>     
> > <snip>
> >
> > I'm looking over the package now.  Sorry for the delay.
> No problem at all. Let me know if you need me to change anything.

I finished looking through the code and the packaging.  The code is not
very good and I found a number of bugs by inspection, but I believe I
have fixed most of them.  I'm still unable to configure an interface
with it, but that may be a driver bug, so I uploaded the result anyway.

The patches I added are:

004_fix_ctype_usage.diff
- fixes incorrect use of C library character type functions
005_fix_extraction_checks.diff
- fixes error handling in some string parsing code
006_fix_temporary_c_str.diff
- fixes use of c_str() on a temporary object which will be destroyed
007_fix_buffer_lengths.diff
- fixes a couple of buffer length mismatches (not exploitable)
008_fix_row_toggled.diff
- should fix row selection where there are more than 10 rows in a table
010_fix_cflags.diff
- makes DEB_BUILD_OPTIONS=noopt work, and makes --debug disable
  stripping (these could be separated)
011_fix_trayicon_toggle.diff
- fixes showing the tray icon after it's been hidden (I think this may
  be broken by a bug in GtkPlug, but I'm not sure)
012_fix_set_ip.diff
- makes set_ip.sh use pkill rather than a fragile kill/ps combination;
  removes bogus use of dhcpd (that's a DHCP *server*, not a client)
013_fix_install_failure.diff
- makes "make install" fail if rutilt is missing
014_make_dialogs_transient.diff
- makes various dialogs transient for the main window; this is useful
  for some window managers
015_use_su-to-root.diff
- makes helper_launcher.sh use the su-to-root script from menu, which
  will do a better job of finding a graphical su program

These should be suitable for upstream, except for 015 and of course the
debian/rules bit of 010.

> > If you don't mind, I would like to bring rutilt into the pkg-ralink
> > project so it's easier to coordinate updates to drivers and rutilt.
> Of course; this means you will take care of this in the future I guess?
> Just in case, a little update of what should come: I have discussed some 
> of the patches and issues with upstream, and I expect that in the next 
> issue there won't be a need for the 3 patches. Also the error during 
> build (the check for the kernel presence) should be resolved.

I changed the configuration options, replacing --force with
--kernel_sources=/usr.  That makes configure.sh look in
/usr/include/linux/wireless.h which it seems to be happy with.

> PS. Since I wrote my email to your list, I made a couple of small 
> changes to the package and on Friday the 14th I have uploaded again the 
> package to mentors; I hope this is the version you are looking at.

I think so, but please check the repository
<svn://svn.debian.org/svn/pkg-ralink> to see whether I missed any
changes.  And please create a guest account on Alioth so we can add you
to the pkg-ralink project.

Ben.

-- 
Ben Hutchings
Power corrupts.  Absolute power is kind of neat.
                           - John Lehman, Secretary of the US Navy 1981-1987
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.alioth.debian.org/pipermail/pkg-ralink-maintainers/attachments/20071008/65aeda92/attachment.pgp