[request-tracker-maintainers] rt-extension-assettracker

Dominic Hargreaves dom at earth.li
Sun Apr 24 11:24:17 UTC 2011


On Thu, Apr 21, 2011 at 03:48:43PM -0700, Bradley Bell wrote:
> I think the AT package is basically ready now, if you'd like to look it over:
> http://git.debian.org/?p=pkg-request-tracker/rt-extension-assettracker.git;a=summary

This package is looking pretty good, but I do have some minor comments.
Note that these are just based on reading through, and a quick build of
the package -- which worked fine. I haven't done any testing, so can't
comment on how well the package works. How much testing has this had so
far?

- debian/copyright: please include Copyright information about the
  scripts you've taken from rt-rtfm. There is an explicit paragraph
  about this. Also, it this really all Copyright BPS? I know the
  licence tags are all over the place, but the contents of the README
  leads me to suspect that they weren't particularly involved in 
  authoring this. It would be interesting to check this out.

- please install the lintian override with dh_lintian (should just
  need to move the file to
  debian/rt3.8-extension-assettracker.lintian-overrides)

- Patches: please include DEP3 patch tags:
  <http://dep.debian.net/deps/dep3/>

- Please fill in the boilerplate in debian/po/templates.pot

- Please check and update Standards-Version to the latest from Policy

- There seems to be missing deps on libxml-parser-perl and
  libxml-simple-perl

- rt-wrapper-debian isn't used at all as far as I can see; should it
  be removed?

- I notice that this release is labelled a beta. Presumably it's proven
  itself usable in practice, and therefore suitable for uploading to
  unstable (rather than, for example, experimental)?

As I was doing this review I realised that we could probably do with an
extension helper package, to include at least the scripts you copied from
rt-rtfm, but potentially more. I did start preparing such a package
yesterday, but I realised that it probably needed a bit more careful thought
and design than a quick refactoring of the existing scripts, so it's
probably not something which should hold you up.

All that said though, this package is nearly there, and I'd be happy to
see the package uploaded under the pkg-request-tracker banner with those
minor problems fixed. Thanks!

Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)



More information about the pkg-request-tracker-maintainers mailing list