[request-tracker-maintainers] reckuest-tracker4 improvements

[Dominic Hargreaves]

On Fri, Jan 13, 2012 at 11:37:01PM +1100, Dmitry Smirnov wrote:
> Dear Dominic,
> 
> Thank you for your work on request-tracker package.
> 
> I'd like to join your friendly team with some little improvements of mine.

Great, thanks for the interest! You'll want to join the mailing list at
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-request-tracker-maintainers>
as a starting point.

> Please find attached
> 
>   * Patch to fix debian/watch

Good catch.

>   * Patch to update debian/copyright to DEP-5 format 
>     and to include contributor's copyrights
>     (Is it correct that the license for debian/* files is GPL-2+ ?)

The contributors have not included any different license, so it's a
reasonable assumption.

>   * Patch to add new package rt4-fcgi 
>     (also providing nginx configuration example 
>      and adding myself to uploaders)

Okay. I think there is already a bug about providing alternatives to
Apache, but I can't find it right now.

>   * Patch to add the changes above to debian/changelog

debian/changelog entries should, where possible, be included in the
patch/commit to which they relate, rather than separate - makes it much
easier to pick out the relevant changes.

> Perhaps the most important addition is rt4-fcgi together nginx configuration, 
> which is undocumented upstream and rather non-trivial due to obscure 
> "SCRIPT_NAME" parameter.

Incidentally, you should normally set the distribution in a changelog
entry to UNRELEASED unless you are finalising an entry just before upload.

> Just wondering why we're using a private 'ckeditor' copy instead of depending 
> on 'ckeditor' package? 
> Is there are a technical problem with this?

IIRC the precise version of ckeditor is needed - previously, if it now,
upstream modified ckeditor in place.

I'll review your patches in more detail later.

Thanks,
Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)