[request-tracker-maintainers] Review: request-tracker4 improvements

[Dominic Hargreaves]

I've only quoted parts which I'm commenting on.

On Fri, Jan 13, 2012 at 11:37:01PM +1100, Dmitry Smirnov wrote:

> diff --git a/debian/watch b/debian/watch
> index 0020306..34d0603 100644
> --- a/debian/watch
> +++ b/debian/watch
> @@ -1,2 +1,2 @@
>  version=3
> -http://bestpractical.com/rt/download_file.html .*/rt-(3\.8.+)\.tar\.gz
> +http://bestpractical.com/rt/download_file.html .*/rt-(\d+\.\d+\.\d+)\.tar\.gz

Well spotted, thanks.

> From adb5c83d78932d47526d7d5f7ab9d3848e9b7410 Mon Sep 17 00:00:00 2001
> From: Dmitry Smirnov <onlyjob at member.fsf.org>
> Date: Fri, 13 Jan 2012 22:45:57 +1100
> Subject: [PATCH 2/4] debian/copyright:
> 
>     - updated to DEP-5
>     - corrected source URL
>     - added copyrights of debian contributors
>     - removed Perl copyright paragraph
> ---
>  debian/copyright |  355 ++++++++++++++++++++++++++----------------------------
>  1 files changed, 168 insertions(+), 187 deletions(-)
> 
> diff --git a/debian/copyright b/debian/copyright
> index f7eb676..2edbc95 100644
> --- a/debian/copyright
> +++ b/debian/copyright

> +Format: http://anonscm.debian.org/viewvc/dep/web/deps/dep5.mdwn?view=markup&pathrev=174

Looks like

http://dep.debian.net/deps/dep5/

is a better URL.

> +Upstream-Name: Request Tracker
> +Upstream-Contact: Jesse Vincent <jesse at bestpractical.com>
> +Source: https://github.com/bestpractical/rt
> +Comment:
> + This package was debianized by Debian Request Tracker Group
> + <pkg-request-tracker-maintainers at lists.alioth.debian.org>
> + on Wed, 30 Aug 2006 00:43:38 -0400
> +
> +Files: debian/*
> +Copyright: © 2011-2012 Dominic Hargreaves <dom at earth.li>
> +Copyright: © 2012      Dmitry Smirnov <onlyjob at member.fsf.org>
> +Copyright: © 2009      Niko Tyni <ntyni at debian.org>
> +Copyright: © 2008      Gerardo Curiel <gcuriel at debian.org.ve> 
> +License: GPL-2+

I'm not aware of any decision to change the licensing, so this should be
GPL-2, just like RT itself.

The copyright years do not reflect the real state of contributions; mine
go back to 2008, and Niko's go further (probably see the changelog to
request-tracker3.{8,6,4}. Ths list of contributors is also incomplete;
if we're going to include a list at all, it may as well be complete
(again, see the older packages).

Otherwise, this patch looks fine - thanks for a thorough job.

> Subject: [PATCH 3/4] rt4-fcgi package and sample nginx configuration

> diff --git a/debian/conf/nginx/request-tracker4.conf b/debian/conf/nginx/request-tracker4.conf
> new file mode 100644
> index 0000000..e93ccb4
> --- /dev/null
> +++ b/debian/conf/nginx/request-tracker4.conf
> @@ -0,0 +1,22 @@
> +# request-tracker4 configuration for nginx
> +# (belong to /etc/nginx/conf.d)
> +location /rt {
> +	alias		/usr/share/request-tracker4/html;
> +
> +	expires		epoch;
> +	include		/etc/nginx/fastcgi_params;
> +	fastcgi_param	SCRIPT_NAME		"/rt";
> +	fastcgi_pass	unix:/var/run/rt4-fcgi.sock;
> +}
> +
> +# Bypass FastCGI for images
> +location /rt/NoAuth/images {
> +	alias		/usr/share/request-tracker4/html/NoAuth/images/;
> +}
> +
> +# Limit mail gateway access to localhost by default
> +location /rt/REST/1.0/NoAuth {
> +	allow		127.0.0.1;
> +	deny		all;
> +}
> +

This looks plausible, but I haven't used nginx so can't comment further.

> +# Defaults for request-tracker4 initscript
> +# sourced by /etc/init.d/rt4-fcgi
> +# installed at /etc/default/rt4-fcgi by the maintainer scripts

Being very picky here... this file is shipped in place in the .deb,
not installed by a maintainer script.

> diff --git a/debian/control b/debian/control
> index 3f18585..deb0d29 100644
> --- a/debian/control
> +++ b/debian/control

> +Description: Nginx specific files for request-tracker4
> + Request Tracker (RT) is a ticketing system which
> + enables a group of people to intelligently and efficiently manage
> + tasks, issues, and requests submitted by a community of users. It
> + features web, email, and command-line interfaces (see the package
> + rt4-clients).
> + .
> + This package provides the 4 series of RT. It can be installed alongside
> + the 3.8 series without any problems. 
> + .
> + RT is a high-level, portable, platform independent system that eases
> + collaboration within organizations and makes it easy for them to take care
> + of their customers.
> + .
> + RT manages key tasks such as the identification, prioritization,
> + assignment, resolution, and notification required by
> + enterprise-critical applications, including project management, help
> + desk, NOC ticketing, CRM, and software development.
> + .
> + This package provides fcgi interface for nginx web server
> + (but not limited to).

I'd reword this to:

This package provides an FCGI interface for web servers including,
but not limited to, nginx.

I'll follow up to your later email with a suggestion for how to proceed.

Thanks,
Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)