[request-tracker-maintainers] reckuest-tracker4 improvements

Dmitry Smirnov onlyjob at member.fsf.org
Wed Jan 25 10:37:51 UTC 2012


Hi Dominic,

On Wed, 25 Jan 2012 07:16:55 Dominic Hargreaves wrote:
> > 
> > For some reason I thought that if you only want to apply some of my
> > changes but not all of them this could make cherry-picking easier.
> 
> Maybe - although including changelog entries with the commit means that
> it's harder for changelog entries to go missing :)


Totally agree.


> > With your permission I can properly push the proposed changes one by one,
> > accompanied with changelog notes.
> 
> I provided some more review in an email I just sent (sorry about the
> delay).

No worries, there is no rush.

> 
> In the first instance, could you provide another set of patches to
> apply (and I propose to look at them more quickly this time!)
> 

Please find updated patches attached. (All your suggestions are implemented)


> > > 
> > > IIRC the precise version of ckeditor is needed - previously, if it now,
> > > upstream modified ckeditor in place.
> 
> Ugh, must have been tired when I wrote that.

:)  Frankly my English literally shuts down when I'm tired. :(


> > Interesting. Is this worth mentioning in README.source ?
> 
> It's mentioned in debian/lintian-overrides, although I don't recall
> the precise nature of the customisations now (the upstream git repo
> may know better than I do).

Ultimately this is up to you and I might be wrong about it but in my opinion 
this information belong to README.source

But never mind if you are disagree as this is not somewhat important.

Regards,
Dmitry.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-debian-copyright-to-DEP-5.patch
Type: text/x-patch
Size: 15690 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-request-tracker-maintainers/attachments/20120125/47805528/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-debian-watch-is-updated.patch
Type: text/x-patch
Size: 1023 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-request-tracker-maintainers/attachments/20120125/47805528/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-new-rt4-fcgi-package-and-sample-nginx-configuration.patch
Type: text/x-patch
Size: 9448 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-request-tracker-maintainers/attachments/20120125/47805528/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-request-tracker-maintainers/attachments/20120125/47805528/attachment-0001.pgp>


More information about the pkg-request-tracker-maintainers mailing list