[DRE-maint] Bug#405070: Freezes upon IMAP error

[Lucas Nussbaum]

tags 405070 + pending
thanks

On 30/12/06 at 22:01 +0000, Joachim Breitner wrote:
> Package: feed2imap
> Version: 0.8-2
> Severity: important
> 
> Hi,
> 
> I just came across this problem (reproducible with cache file and imap
> folders removed):
> 
> Something goes wrong with the uploading of the entries, and feed2imap
> just sits there. strace tells me that both imap server and feed2imap are
> waiting for each other (select’ing each other’s pipe). ngrep tells me
> this:
> 
>   RUBY0401 NO Error in IMAP command received by server...
> 
> One assumption is that the feed is bad, because of the date 1-Jan-1970
> 01:00:00 +0000 of some entries
> (see http://www.joachim-breitner.de/heisse-news/index.rss)
> 
> But even if the data is wrong, it should handle errors gracefuly, with
> an error message and with exiting the program.
> 
> Indeed, removing  this feed from the list makes feed2imap run through.

Hi,

Actually, Ruby's IMAP library uses a monitor implementation. But this
implementation seems to suck at handling exceptions. So, when an error
occurs, it's useless to try to continue to use an existing connection.

I've changed feed2imap to exit(1) when an error is received from the
IMAP server. This should help debugging such issues. However, I'm not
100% sure that this fixes the problem in your case: if the imap lib
doesn't notice the error, it will just continue to try and get
deadlocked.

Don't hesitate to reopen if you can reproduce that with feed2imap
0.9.2-1 (to be uploaded in a 1 or 2 weeks).
-- 
| Lucas Nussbaum
| lucas at lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas at nussbaum.fr             GPG: 1024D/023B3F4F |