[DRE-maint] RFS: libglobalhotkeys-ruby
vinc4mai at gmail.com
Wed Aug 4 11:56:55 UTC 2010
2010/8/4, Lucas Nussbaum <lucas at lucas-nussbaum.net>:
> Quick review:
> - use english for commit messages :-)
> - changelog: UNRELEASED -> unstable
> - you should have a libglobalhotkeys-ruby1.8 that contains the actual
> files, as well as a libglobalhotkeys-ruby package that simply depends
> on libglobalhotkeys-ruby (see the other packages in the repo)
> - no '.' at end of Description's first line.
> - use sentences in long description.
> - in rules, use the cdbs classes provided by the team, not the default
> debhelper template (see other packages)
> - your library is loaded using require 'rghk', so I think that it makes
> more sense to name the package librghk-ruby.
>> I still have two lintian infos :
>> Do you think I should rephrase the description or use doc-base ?
> Yes, probably both.
> | Lucas Nussbaum
> | lucas at lucas-nussbaum.net http://www.lucas-nussbaum.net/ |
> | jabber: lucas at nussbaum.fr GPG: 1024D/023B3F4F |
Thanks for your review.
I will take a look at cdbs and doc-base which I do not know.
I will let you know when I have done taking acount of your remarks.
Sorry for the french commit message :(. I had to be sleepy when I made it.
More information about the Pkg-ruby-extras-maintainers