[DRE-maint] Bug#888124: ruby-fakeweb: FTBFS on ruby2.5: undefined method `close' for #<FakeWeb::StubSocket:0x000055834e7de408>

[Chris West (Faux)]

Source: ruby-fakeweb
Version: 1.3.0+git20131202.48208f9+dfsg-3
Severity: important
User: debian-ruby at lists.debian.org
Usertags: ruby2.5

Dear Maintainer,

This package fails to build against ruby2.5. Soon, there will
be a transition to ruby2.5, and this package will FTBFS in sid.

There may be some details on the wiki about common problems:
https://wiki.debian.org/Teams/Ruby/Ruby25Transition

Build log excerpt:


188 runs, 359 assertions, 0 failures, 0 errors, 0 skips
/usr/bin/ruby2.5 /usr/bin/gem2deb-test-runner

┌──────────────────────────────────────────────────────────────────────────────┐
│ Checking Rubygems dependency resolution on ruby2.5                           │
└──────────────────────────────────────────────────────────────────────────────┘

GEM_PATH=debian/ruby-fakeweb/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 -e gem\ \"fakeweb\"

┌──────────────────────────────────────────────────────────────────────────────┐
│ Run tests for ruby2.5 from debian/ruby-tests.rb                              │
└──────────────────────────────────────────────────────────────────────────────┘

RUBYLIB=/build/ruby-fakeweb-1.3.0+git20131202.48208f9+dfsg/debian/ruby-fakeweb/usr/lib/ruby/vendor_ruby:. GEM_PATH=debian/ruby-fakeweb/usr/share/rubygems-integration/all:/root/.gem/ruby/2.5.0:/var/lib/gems/2.5.0:/usr/lib/x86_64-linux-gnu/rubygems-integration/2.5.0:/usr/share/rubygems-integration/2.5.0:/usr/share/rubygems-integration/all ruby2.5 debian/ruby-tests.rb
Run options: --seed 13512

# Running:

..................................................E.EEEEEEEEEE...EEEFFEEF.E.EE...EEE......F..EE......E.E..E...EE.....EE...EF...FEEEEEEEEE...E.....................EFE.EF..EF.......EEEEEEEE.

Finished in 0.103453s, 1817.2499 runs/s, 2590.5477 assertions/s.

  1) Error:
TestFakeWebTrailingSlashes#test_registering_root_with_slash_and_request:
NoMethodError: undefined method `close' for #<FakeWeb::StubSocket:0x000055834e7de408>
Did you mean?  closed?
               clone
    /usr/lib/ruby/2.5.0/net/http.rb:1014:in `do_finish'
    /usr/lib/ruby/2.5.0/net/http.rb:912:in `start'
    /usr/lib/ruby/2.5.0/net/http.rb:609:in `start'
    /build/ruby-fakeweb-1.3.0+git20131202.48208f9+dfsg/test/test_trailing_slashes.rb:23:in `test_registering_root_with_slash_and_request'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:107:in `block (3 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:204:in `capture_exceptions'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:104:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:255:in `time_it'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:103:in `block in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:350:in `on_signal'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:275:in `with_info_handler'
    /usr/lib/ruby/vendor_ruby/minitest/test.rb:102:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:839:in `run_one_method'
    /usr/lib/ruby/vendor_ruby/minitest.rb:324:in `run_one_method'
    /usr/lib/ruby/vendor_ruby/minitest.rb:311:in `block (2 levels) in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:310:in `each'
    /usr/lib/ruby/vendor_ruby/minitest.rb:310:in `block in run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:350:in `on_signal'
    /usr/lib/ruby/vendor_ruby/minitest.rb:337:in `with_info_handler'
    /usr/lib/ruby/vendor_ruby/minitest.rb:309:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:159:in `block in __run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:159:in `map'
    /usr/lib/ruby/vendor_ruby/minitest.rb:159:in `__run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:136:in `run'
    /usr/lib/ruby/vendor_ruby/minitest.rb:63:in `block in autorun'

  2) Error:
TestFakeWebTrailingSlashes#test_registering_root_without_slash_and_request:
NoMethodError: undefined method `close' for #<FakeWeb::StubSocket:0x000055834e6368f8>
Did you mean?  closed?
               clone
    /usr/lib/ruby/2.5.0/net/http.rb:1014:in `do_finish'
    /usr/lib/ruby/2.5.0/net/http.rb:912:in `start'
    /usr/lib/ruby/2.5.0/net/http.rb:609:in `start'
    /build/ruby-fakeweb-1.3.0+git20131202.48208f9+dfsg/test/test_trailing_slashes.rb:12:in `test_registering_root_without_slash_and_request'

...

188 runs, 268 assertions, 9 failures, 54 errors, 0 skips
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /build/ruby-fakeweb-1.3.0\+git20131202.48208f9\+dfsg/debian/ruby-fakeweb returned exit code 1
debian/rules:6: recipe for target 'binary' failed
make: *** [binary] Error 1
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

Full build log:
https://rbuild.fau.xxx/2018-01-23/ruby-fakeweb.log

Please fix it!

Cheers,
Chris.