[DRE-maint] Bug#919072: schleuder: FTBFS in both buster and sid

[Santiago Vila]

Package: src:schleuder
Version: 3.3.0-6
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules binary-indep
dh binary-indep --buildsystem=ruby --with ruby
   dh_update_autotools_config -i -O--buildsystem=ruby
   dh_autoreconf -i -O--buildsystem=ruby
   dh_auto_configure -i -O--buildsystem=ruby
	dh_ruby --configure
   dh_auto_build -i -O--buildsystem=ruby
	dh_ruby --build
   dh_ruby --build
   dh_auto_test -i -O--buildsystem=ruby
	dh_ruby --test
   create-stamp debian/debhelper-build-stamp
   dh_testroot -i -O--buildsystem=ruby
   dh_prep -i -O--buildsystem=ruby

[... snipped ...]

Failures:

  1) user sends a plain text message from thunderbird being signed-inline
     Failure/Error: expect(error).to be_empty
       expected `"Error: A serious, unhandleable error happened. Please contact the administrators of this system or service and provide them with the following information:\n\ninvalid byte sequence in US-ASCII\n".empty?` to return true, got false
     # ./spec/schleuder/integration/send_plain_spec.rb:18:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:47:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:46:in `block (2 levels) in <top (required)>'

  2) user sends keyword x-resend with utf-8 body and umlauts
     Failure/Error: expect(message.parts[1].body.to_s.force_encoding(message.parts[1].charset)).to eql(content_body.encode(message.parts[1].charset))

       expected: "This is a test\nAnd here are some umlauts:\u00C4\u00E4\u00D6\u00F6\u00DC\u00FC\u00DF"
            got: "This is a test\r\nAnd here are some umlauts:\u00C4\u00E4\u00D6\u00F6\u00DC\u00FC\u00DF"

       (compared using eql?)
     # ./spec/schleuder/integration/keywords_spec.rb:1923:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:47:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:46:in `block (2 levels) in <top (required)>'

  3) user sends keyword x-resend with iso-8859-1 body
     Failure/Error: expect(message.parts[1].body.to_s.force_encoding(message.parts[1].charset)).to eql(content_body.encode(message.parts[1].charset))

       expected: "Hello again! \xA1Hola!\n"
            got: "Hello again! \xA1Hola!\r\n"

       (compared using eql?)
     # ./spec/schleuder/integration/keywords_spec.rb:1881:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:47:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:46:in `block (2 levels) in <top (required)>'

Finished in 4 minutes 38.7 seconds (files took 2.25 seconds to load)
375 examples, 3 failures

Failed examples:

rspec './spec/schleuder/integration/send_plain_spec.rb[1:2]' # user sends a plain text message from thunderbird being signed-inline
rspec ./spec/schleuder/integration/keywords_spec.rb:1890 # user sends keyword x-resend with utf-8 body and umlauts
rspec ./spec/schleuder/integration/keywords_spec.rb:1848 # user sends keyword x-resend with iso-8859-1 body

Randomized with seed 23471

/usr/bin/ruby2.5 /usr/bin/rspec --format documentation failed
ERROR: Test "ruby2.5" failed. Exiting.
dh_auto_install: dh_ruby --install /<<PKGBUILDDIR>>/debian/schleuder returned exit code 1
make: *** [debian/rules:7: binary-indep] Error 1
dpkg-buildpackage: error: debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made in my autobuilder with "dpkg-buildpackage -A"
but this kind of failure (extra \r in the expected output) also happens here

https://tests.reproducible-builds.org/debian/rbuild/buster/amd64/schleuder_3.3.0-6.rbuild.log.gz

If this is the result of some ongoing transition, please consider fixing the FTBFS problem
in sid at least (which is different).

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.