<div dir="ltr">Some comments below:<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 19, 2013 at 7:00 AM, Scott Kitterman <span dir="ltr"><<a href="mailto:ftpmaster@ftp-master.debian.org" target="_blank">ftpmaster@ftp-master.debian.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Unfortunately, the rails-4.0 is not in a condition to be accepted in the Debian<br>
archive at the moment. Â In my review, I found a number of issues major and<br>
minor that should be corrected. Â Some of these may exist in the existing rails<br>
package, I did not check. Â If so, these are bugs in the package.<br>
<br>
There is no need to ship debian/patches/series as an empty file in format 3.0<br>
(quilt). Â It will be created if needed.<br></blockquote><div><br></div><div>That is surely not a reason while to reject package, right?</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
All of the Conflicts/Replaces relationships in debia/control should be<br>
Breaks/Replaces.<br></blockquote><div><br></div><div>Mostly done with the exception of virtual packages.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
There is at least one case of an extra copy of the MIT license file being<br>
installed. Â These should be removed.<br>
usr/lib/ruby/vendor_ruby/rails/generators/rails/plugin_new/templates/MIT-LICENSE<br></blockquote><div><br></div><div>Nope, the license file is there for templating new projects and has it's place there.</div><div>Â </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
actionpack/lib/action_dispatch/journey/parser.rb is a generated file. Â It looks<br>
like the source needed to regenerate it during build (parser.y) is there, but<br>
the package build does not do this. Â The generated file is not the preferred<br>
form of modification, so in Debian we need to ensure the identical file can be<br>
generated. Â The best way to do this is to regenerate it during package build. In<br>
some cases, it's OK to just manually verify things can be rebuilt and not do it<br>
during the build, but only if there is a substantial barrier to actually<br>
rebuilding it. Â That's unlikely to be the case here.<br></blockquote><div><br></div><div>Regenerating parser.rb with racc now.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Although there is not confusion about the intended license, it is better for the<br>
license header to be put in each file rather than just a copy of the license in<br>
each top level directory (there are some files that do have this). (not a reject<br>
issue, but something you might discuss with upstream)<br>
<br>
Files copyright David Heinemeier Hansson are Copyright (c) 2004-2013 David<br>
Heinemeier Hansson and not just 2004.<br></blockquote><div><br></div><div>Fixed.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The following files are Copyright (c) 2006 Assaf Arkin (<a href="http://labnotes.org" target="_blank">http://labnotes.org</a>) and<br>
under MIT and/or CC By license:<br>
actionpack/test/controller/selector_test.rb<br>
actionpack/test/controller/assert_select_test.rb<br>
actionpack/lib/action_view/vendor/html-scanner/html/selector.rb<br>
actionpack/lib/action_dispatch/testing/assertions/selector.rb<br>
Needs to be documented in debian/copyright.<br></blockquote><div><br></div><div>Fixed.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This icons in guides/assets/images/icons (as indicated in the README) were done<br>
by Stuart Rackham based on work by Jakub Steiner that appears to be © Jakub<br>
Steiner, © Novell, Inc.  As indicated on the referenced web page, these are<br>
probably licensed GPL v2, but it's not clear and not documented in debian/<br>
copyright regardless. Â License needs to be clarified and documented.<br></blockquote><div>Â <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
guides/assets/javascripts/syntaxhighlighter/shBrushCpp.js is also Copyright 2006<br>
Shin, YoungJin. Â The additional copyright holder needs to be documented.<br></blockquote><div><br></div><div>Removed full guides/ directory from +dfsg repacked, since it's just documentation available on the web. It might get repackaged in the future when we clear the licensing of all files.</div>
<div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The following jpegs have no clear license and are copyright of other parties.<br>
Their license needs to be clarified and (if free) documented in<br>
debian/copyright. Â Otherwise they need to be removed from the package:<br>
actionpack/test/fixtures/multipart/mona_lisa.jpg is Copyright 1995 Nicolas<br>
Piochÿ with no license information.<br></blockquote><div><br></div><div>Removed. It's licensed under PD-Art (from wikimedia).</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
guides/assets/images/jaimeiniesta.jpg says Copyright 2006, but no indication of<br>
who the copyright holder is.<br>
<br>
guides/assets/images/vijaydev.jpg is Copyright 2007 Apple Inc., all rights<br>
reserved.<br>
<br>
guides/assets/images/rails_guides_kindle_cover.jpg is Copyright 2007 Apple Inc.,<br>
all rights reserved<br></blockquote><div><br></div><div>If you look at the contents of the files it's quite clear that the Apple Inc. copyright is some boilerplate from software that generated the picture. I am quite sure that the guides/ author's picture is not copyrighted by Apple.</div>
<div><br></div><div>Same with the other author's picture. But I guess it needs clarification from them.</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Please address these issues and reupload.<br></blockquote><div><br></div><div>Done.</div><div><br></div><div>Thanks for the review,</div><div>Ondrej</div><div>Â </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Scott K<br>
<br>
<br>
===<br>
<br>
Please feel free to respond to this email if you don't understand why<br>
your files were rejected, or if you upload new files which address our<br>
concerns.<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Ondřej Surý <<a href="mailto:ondrej@sury.org" target="_blank">ondrej@sury.org</a>><br>
</div></div>