[Pkg-samba-maint] Bug#453350: Ubuntu- and Debian-clean LSB init script use

[Steve Langasek]

Package: samba
Version: 3.0.27a-1
Severity: minor
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch hardy

The current samba init script calls both log_daemon_msg and log_progress_msg
when stopping the daemons.  While it seems obvious that passing a daemon
name as the second argument to log_daemon_msg would have the same behavior
as passing it to log_progress_msg, in practice this is not the case on
Ubuntu; the second argument to log_daemon_msg is normally displayed, and the
argument to log_progress_msg is normally suppressed.  This results in
confusing behavior, because the user will see that nmbd is stopped but not
smbd. (https://bugs.launchpad.net/ubuntu/+source/samba/+bug/25803)

The following short patch adjusts samba.init to call log_progress_msg for
each daemon on stop.  This is already consistent with the behavior on start,
which was previously changed for unrelated reasons (because control of each
of nmbd and smbd through the init script is now optional).

Ok to apply?

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: log_daemon_msg-ubuntu.diff
Type: text/x-diff
Size: 439 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20071128/480d9e3d/attachment.diff