[Pkg-samba-maint] Bug#448546: samba: fix a useless debug message

[Josip Rodin]

Package: samba
Version: 3.0.24-6etch4
Tags: upstream

Hi,

I used to encounter many messages like these:

[2007/10/29 23:34:47, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2217)
  ldapsam_getgroup: Did not find group
[2007/10/29 23:34:47, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2217)
  ldapsam_getgroup: Did not find group
[2007/10/29 23:34:47, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2217)
  ldapsam_getgroup: Did not find group
[2007/10/29 23:34:47, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2217)
  ldapsam_getgroup: Did not find group
[2007/10/29 23:34:47, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2217)
  ldapsam_getgroup: Did not find group

This was wholly useless and confusing :) So I patched it:

--- samba-3.0.24/source/passdb/pdb_ldap.c       2007-02-04 19:59:21.000000000 +0100
+++ samba-3.0.24/source/passdb/pdb_ldap.c       2007-10-29 23:02:01.000000000 +0100
@@ -2214,7 +2214,8 @@
        count = ldap_count_entries(priv2ld(ldap_state), result);
 
        if (count < 1) {
-               DEBUG(4, ("ldapsam_getgroup: Did not find group\n"));
+               DEBUG(4, ("ldapsam_getgroup: Did not find group, filter was %s\n",
+                         filter));
                ldap_msgfree(result);
                return NT_STATUS_NO_SUCH_GROUP;
        }

Now those logs make at least some remote sense:

[2007/10/29 23:37:11, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2218)
  ldapsam_getgroup: Did not find group, filter was (&(objectClass=sambaGroupMapping)(sambaSID=S-1-5-32-544))
[2007/10/29 23:37:11, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2218)
  ldapsam_getgroup: Did not find group, filter was (&(objectClass=sambaGroupMapping)(sambaSID=S-1-5-32-545))
[2007/10/29 23:37:11, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2218)
  ldapsam_getgroup: Did not find group, filter was (&(objectClass=sambaGroupMapping)(sambaSID=S-1-1-0))
[2007/10/29 23:37:11, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2218)
  ldapsam_getgroup: Did not find group, filter was (&(objectClass=sambaGroupMapping)(sambaSID=S-1-5-2))
[2007/10/29 23:37:11, 4] passdb/pdb_ldap.c:ldapsam_getgroup(2218)
  ldapsam_getgroup: Did not find group, filter was (&(objectClass=sambaGroupMapping)(sambaSID=S-1-5-32-546))

No idea if it's too verbose for log level 4, but the old message was
certainly pointless, whatever the level.

Please apply this (upstream). TIA.

-- 
     2. That which causes joy or happiness.