[Pkg-samba-maint] Bug#448686: Bug#448686: samba: /it's own/s/'//

Christian Perrier bubulle at debian.org
Wed Oct 31 17:47:30 UTC 2007


tags 448686 patch upstream
thanks

Quoting Justin Pryzby (jpryzby+d at quoininc.com):
> Package: samba
> Version: 3.0.24-6etch4
> Severity: minor
> 
> "its" is possessive; "it's" is contractive.  I grepped /usr/bin/ and
> found that a handful of samba binaries include the phrase: "it's own"
> which is always wrong.  It's (put acknowledged but not intended) worse
> than "its not" (which is also always wrong) since it's not simply
> ommision of an uncommon character but extraneous insertion thereof.


Nice catch. Actually, this spelling error appears only in one file in
the source code.

However, a few comments use the wrong spelling as well and the
attached patch fixes this in both comments and source code.



-------------- next part --------------
diff -Nru samba-3.2.0pre1.old/source/lib/ldb/common/ldb_dn.c samba-3.2.0pre1/source/lib/ldb/common/ldb_dn.c
--- samba-3.2.0pre1.old/source/lib/ldb/common/ldb_dn.c	2007-10-31 18:04:46.437397008 +0100
+++ samba-3.2.0pre1/source/lib/ldb/common/ldb_dn.c	2007-10-31 18:42:10.839671458 +0100
@@ -26,7 +26,7 @@
  *
  *  Component: ldb dn explode and utility functions
  *
- *  Description: - explode a dn into it's own basic elements
+ *  Description: - explode a dn into its own basic elements
  *                 and put them in a structure
  *               - manipulate ldb_dn structures
  *
diff -Nru samba-3.2.0pre1.old/source/lib/replace/replace.c samba-3.2.0pre1/source/lib/replace/replace.c
--- samba-3.2.0pre1.old/source/lib/replace/replace.c	2007-10-31 18:04:45.437447153 +0100
+++ samba-3.2.0pre1/source/lib/replace/replace.c	2007-10-31 18:41:54.340503665 +0100
@@ -218,7 +218,7 @@
 #ifndef HAVE_MEMMOVE
 /*******************************************************************
 safely copies memory, ensuring no overlap problems.
-this is only used if the machine does not have it's own memmove().
+this is only used if the machine does not have its own memmove().
 this is not the fastest algorithm in town, but it will do for our
 needs.
 ********************************************************************/
diff -Nru samba-3.2.0pre1.old/source/passdb/pdb_ldap.c samba-3.2.0pre1/source/passdb/pdb_ldap.c
--- samba-3.2.0pre1.old/source/passdb/pdb_ldap.c	2007-10-31 18:04:50.437196421 +0100
+++ samba-3.2.0pre1/source/passdb/pdb_ldap.c	2007-10-31 18:42:35.338435731 +0100
@@ -5285,7 +5285,7 @@
 		}
 
 		if (user_gid == group_gid) {
-			DEBUG (3, ("ldapsam_change_groupmem: can't remove user from it's own primary group!\n"));
+			DEBUG (3, ("ldapsam_change_groupmem: can't remove user from its own primary group!\n"));
 			return NT_STATUS_MEMBERS_PRIMARY_GROUP;
 		}
 	}
diff -Nru samba-3.2.0pre1.old/source/smbd/lanman.c samba-3.2.0pre1/source/smbd/lanman.c
--- samba-3.2.0pre1.old/source/smbd/lanman.c	2007-10-31 18:04:39.937722949 +0100
+++ samba-3.2.0pre1/source/smbd/lanman.c	2007-10-31 18:41:37.341361077 +0100
@@ -1325,7 +1325,7 @@
 	}
 
 	/* If someone sets SV_TYPE_LOCAL_LIST_ONLY but hasn't set
-	   any other bit (they may just set this bit on it's own) they 
+	   any other bit (they may just set this bit on its own) they 
 	   want all the locally seen servers. However this bit can be 
 	   set on its own so set the requested servers to be 
 	   ALL - DOMAIN_ENUM. */
diff -Nru samba-3.2.0pre1.old/source/smbd/trans2.c samba-3.2.0pre1/source/smbd/trans2.c
--- samba-3.2.0pre1.old/source/smbd/trans2.c	2007-10-31 18:04:38.937773093 +0100
+++ samba-3.2.0pre1/source/smbd/trans2.c	2007-10-31 18:41:00.843201938 +0100
@@ -3265,7 +3265,7 @@
  *
  * XXX: this really should be behind the VFS interface. To do this, we would
  * need to alter SMB_STRUCT_STAT so that it included a flags and a mask field.
- * Each VFS module could then implement it's own mapping as appropriate for the
+ * Each VFS module could then implement its own mapping as appropriate for the
  * platform. We would then pass the SMB flags into SMB_VFS_CHFLAGS.
  */
 static const struct {unsigned stat_fflag; unsigned smb_fflag;}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20071031/ea6928c5/attachment.pgp 


More information about the Pkg-samba-maint mailing list