[Pkg-samba-maint] Yet another Ubuntu patch: adding a status section to init script

[Christian Perrier]

Quoting Steve Langasek (vorlon at debian.org):

> Yes, I agree that a 'status' option is a nice thing to have and am in favor
> of including such functionality in the Debian package.
> 
> > Please note that using $DAEMON seems overzealous here.
> 
> Heh, yes, agreed.  Also, what status should it return if smbd is set to run
> from inetd?

Hmmm, do we (and upstream) still support that?

> 
> > Also, "pidofproc" doesn't seem to be available in Debian. That appear
> > to be an Ubutuism.....but we could do the same with "pidof".
> 
> pidofproc is a shell function implemented by /lib/lsb/init-functions, on
> both Ubuntu and Debian; so since we're already using this shell lib, we can

Ah, sorry for missing that. No problem, then.


> > +		pidofproc -p $SMBDPID $DAEMON >/dev/null
> > +		status=$?
> > +		if [ $status -eq 0 ]; then
> > +			log_success_msg "SMBD is running"
> > +		else
> > +			log_failure_msg "SMBD is not running"
> > +		fi
> > +		exit $status
> 
> Hnngh, not clean under set -e.  Ever since the LSB init script lib was
> introduced to Debian, error handling in init scripts has gone downhill...


Hmmm, I fail to understand what's needed here. Sorry for being
dumb..:)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20080330/2e2db999/attachment-0001.pgp