[Pkg-samba-maint] [obnox-guest at alioth.debian.org: r2730 - trunk/samba/debian/patches]

[Michael Adam]

Hi,

I am dragging this to the list after briefly chatting with Steve.

Christian Perrier wrote:
> Quoting Michael Adam (obnox at samba.org):
> > Hi Christian and Steve,
> > 
> > I was not sure whether my account had commit rights.
> > But I think it was a funny way of commenting.
> > I hope that's ok for you... :-)
> > 
> > This patch breaks some shared modules, e.g. acl_tdb and acl_xattr.
> 
> Which is what we noticed in #524048.

Uh thanks, I wasn't aware of the fact that this is already in
bugzilla.

> > So I suggest removing it. I'd also do it if you like (now that I
> > know I can commit...)
>
> I'm in favour of this, which is why I commented the patch in
> debian/patches/series, while keeping it in SVN.
> 
> Steve reverted that commit because of bad use of VCS, which I agree
> with, but he seems also reluctant to drop the patch now. In short, we
> don't necessarily agree together here (or we have a misunderstanding).
> 
> So, I'd first prefer having Steve's agreement to drop the patch.
>
> I think it's better to temporarily have the code bloat while we
> (Steve, Volker and you apparently) are working on a libndr and then
> solve this out when this code is splitted in a library.

Right, I agree that it is more important to have fully functional
binaries that having smaller binaries.

An alternative would be the great libbigballofmud.so that all
binaries link against...

But we need not necessarily remove the complete patch:
The main problem IMHO is smbd, which is missing the symbols when
shared modules are loaded at run time. This might happen with
more modules. I just noticed with the acl_tdb and acl_xattr
modules.
smbd is big anyways, so I will try to modify the patch so that
the .a-trick is just not performed with smbd's objects, and compare
the resulting sizes.

Cheers - Michael

-- 
Michael Adam <ma at sernet.de>  <obnox at samba.org>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20090430/ba21de5e/attachment.pgp>