[Pkg-samba-maint] tevent control file review

[Julien Cristau]

On Mon, Jan  5, 2009 at 21:00:31 +0100, Jelmer Vernooij wrote:

> Hi!
> 
> I hope to upload libtevent, for which I already filed an ITP (509225),
> to Debian experimental at some point in the next few weeks. This package
> is required for libldb. 
> 
> This is the control file that I intend to use; any review and comments
> would be much appreciated.
> 
Hi Jelmer, a couple comments below:

> Source: tevent
> Section: devel
> Priority: optional
> Maintainer: Jelmer Vernooij <jelmer at debian.org>
> Build-Depends: debhelper (>> 5.0.0), libtalloc-dev
> Standards-Version: 3.8.0
> DM-Upload-Allowed: yes

you can probably lose this now :)

> Vcs-Svn: svn://svn.debian.org/pkg-samba/trunk/tevent
> 
> Package: libtevent0
> Architecture: any
> Section: libs
> Depends: ${shlibs:Depends}
> Description: Talloc-based event loop library - shared library
>  tevent is a simple library that can handle the main event loop for an
>  application. It supports three kinds of events: timed events, file
>  descriptors becoming readable or writable and signals.
>  .
>  Talloc is used for memory management, both internally and for private
>  data provided by users of the library.
>  .
>  This package contains the shared library file.
> 
> Package: libtevent-dev
> Section: libdevel
> Architecture: any
> Depends: libc6-dev, libtevent0 (= ${binary:Version})

I think libtevent-dev needs a Depends on libtalloc-dev (as tevent.h
includes <talloc.h>).
For the same reason (and to make static linking work), tevent.pc.in
should probably have 'Requires.private: talloc'.

> Description: Talloc-based event loop library - development files
>  tevent is a simple library that can handle the main event loop for an
>  application. It supports three kinds of events: timed events, file
>  descriptors becoming readable or writable and signals.
>  .
>  Talloc is used for memory management, both internally and for private
>  data provided by users of the library.
>  .
>  This package contains the development files.
> 
HTH,
Julien