[Pkg-samba-maint] DO NOT REPLY [Bug 3775] cifs: cached file modification time attribute is rounded to seconds

samba-bugs at samba.org samba-bugs at samba.org
Wed Jan 13 20:14:12 UTC 2010


------- Comment #15 from jlayton at samba.org  2010-01-13 14:14 CST -------
Looks (In reply to comment #14)
> Created an attachment (id=5167)
 --> (https://bugzilla.samba.org/attachment.cgi?id=5167&action=view) [details]
> revalidate inode if any of the times (atime, ctime, mtime) on the inode are set
> For those fs types which support unix extensions (such as ext2/ext3), we can
> mark inode to get revalidated if any of the times for the inode get set.
> I think adding one more transaction only when times are set is probably cleaner
> than special casing fs types.

Agreed. Basic approach on the patch looks reasonable, but please fix the
comment format to match other multi-line comments in the kernel. You also don't
need that many parenthesis in the if statement.

Even better would be to change the existing "if (!rc)" to:

if (rc)
        goto out;

...which would make that code more readable. Do we have confirmation that this
patch fixes the issue?

Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the Pkg-samba-maint mailing list