[Pkg-samba-maint] Bug#249873: Bug#249873: Patch

Nikolaus Rath Nikolaus at rath.org
Tue Apr 24 20:04:41 UTC 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/24/2012 12:39 PM, Christian PERRIER wrote:
> Quoting Nikolaus Rath (Nikolaus at rath.org):
> 
>> Hmm. I think defaulting to /etc/samba/private now, only to have
>> another transition once we've convinced upstream to comply with
>> FHS is inviting trouble.
>> 
>> If we have to obey FHS, wouldn't it be much easier to just
>> replace fhs-filespaths.patch with a patch that replaces the
>> *default* value for "private dir" to /var/lib/samba/private?
> 
> Good idea, indeed. The simplest one and one not involving any 
> transition, really. You get a GO from my side for this change..:-)

It may be hard to believe, but it gets even better: we can just drop
the patch and change the ./configure options to adjust the default
private dir. Minimally invasive :-).

Patch is attached.

Before the patch:
# testparm -v --parameter-name "private dir"
Load smb config files from /etc/samba/smb.conf
rlimit_max: increasing rlimit_max (1024) to minimum Windows limit (16384)
Processing section "[homes]"
Processing section "[printers]"
Processing section "[print$]"
Loaded services file OK.
Press enter to see a dump of your service definitions

/etc/samba

After the patch:
# testparm -v --parameter-name "private dir"
Load smb config files from /etc/samba/smb.conf
rlimit_max: increasing rlimit_max (1024) to minimum Windows limit (16384)
Processing section "[homes]"
Processing section "[printers]"
Processing section "[print$]"
Loaded services file OK.
Press enter to see a dump of your service definitions

/var/lib/samba


Best,

   -Nikolaus

- -- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iGoEARECACoFAk+XB1gjGmh0dHA6Ly93d3cucmF0aC5vcmcvZ3BncG9saWN5Lmh0
bWwACgkQqa23+K5OQlyGFACfX7v6hYmNYYjFlkjaZy41fG245hYAn1ZWX3M7d/XJ
lL56VndnxTRcnmni
=AP0e
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba.diff
Type: text/x-patch
Size: 2230 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20120424/724fd48e/attachment.bin>


More information about the Pkg-samba-maint mailing list