[Pkg-samba-maint] Bug#803924: samba: missing logrotate for /var/log/samba/log.samba

[Andrew Bartlett]

On Tue, 2015-11-03 at 10:17 +0100, Noël Köthe wrote:
> Package: samba
> Version: 2:4.1.20+dfsg-1
> Severity: normal
> 
> Dear Maintainer,
> 
> running samba as a DC the logfile /var/log/samba/log.samba will
> always increase and fill up the /var partition because the logrotate
> file from samba debian/samba.logrotate in the source and
> /etc/logrotate.d/samba in the installation is missing
> an entry for this file.
> 
> This should fix it (samba-ad-dc has no reload):
> 
> debian/samba.logrotate
> /var/log/samba/log.samba {
>         weekly
>         missingok
>         rotate 7
>         postrotate
>                 /etc/init.d/samba-ad-dc restart > /dev/null
>         endscript
>         compress
>         notifempty
> }
> 
> /var/log/samba/log.smbd {
> ...
> 
> Thx for fixing this small but disk filling bug.;)

We really shouldn't restart samba just to rotate the logs.

Try sending a SIGHUP instead.  However, ideally we would patch a reopen
-logs command into smbcontrol, that would be nicer than sending a
signal.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba