[Pkg-samba-maint] Bug#820794: [PATCH] Re: Bug#820794: smbclient: "cli_list: Error: unable to parse name from info level 260" with Windows 10 shares

[Axel Beckert]

Control: notfound -1 2:4.2.10+dfsg-0+debA
Control: found -1 2:4.2.10+dfsg-0+deb8u3
Control: tag -1 + patch
Control: forwarded -1 https://bugzilla.samba.org/show_bug.cgi?id=11822
Control: severity -1 grave

Hi,

raising the severity to grave as this definitely causes data loss: 

* Files are arbitrarily and non-deterministically skipped during data
  transfer
* There is always the warning from the subject of this bug report, but
  the exit code can still be zero, hence the data loss can even remain
  unnoticed.

Axel Beckert wrote:
> Philippe Cloutier wrote:
> > > I am also experiencing this bug on 2 Debian 8 clients on 2 tested
> > > trying to install a Windows 10 SMB server. 
> > 
> > That is, trying to *access* a Windows 10 SMB server.
> 
> Indeed. It seems to be a Windows 10 only issue. We ran into this with
> BackupPC which uses smbclient to connect to Windows machine.

The one-character patch at the end of the upstream bug report
https://bugzilla.samba.org/show_bug.cgi?id=11822 fixed the issue for
us and we can reliably back up Windows 10 shares with BackupPC via
smbclient again.

Following a proposed patch for a stable update which from my point of view
is absolutely necessary:

diff -Nru samba-4.2.10+dfsg/debian/changelog samba-4.2.10+dfsg/debian/changelog
--- samba-4.2.10+dfsg/debian/changelog	2016-06-01 17:10:44.000000000 +0200
+++ samba-4.2.10+dfsg/debian/changelog	2016-09-20 15:15:47.000000000 +0200
@@ -1,3 +1,10 @@
+samba (2:4.2.10+dfsg-0+deb8u4) jessie; urgency=medium
+
+  * Fix smbclient with Windows 10 (Closes: #820794) by adding
+    patch from https://attachments.samba.org/attachment.cgi?id=11971
+
+ -- Axel Beckert <beckert at phys.ethz.ch>  Tue, 20 Sep 2016 15:13:44 +0200
+
 samba (2:4.2.10+dfsg-0+deb8u3) jessie-security; urgency=high
 
   * Non-maintainer upload by the Security Team.
diff -Nru samba-4.2.10+dfsg/debian/patches/s3_libsmb_Fix_error_where_short_name_length_was_read_as_2_affects_win10 samba-4.2.10+dfsg/debian/patches/s3_libsmb_Fix_error_where_short_name_length_was_read_as_2_affects_win10
--- samba-4.2.10+dfsg/debian/patches/s3_libsmb_Fix_error_where_short_name_length_was_read_as_2_affects_win10	1970-01-01 01:00:00.000000000 +0100
+++ samba-4.2.10+dfsg/debian/patches/s3_libsmb_Fix_error_where_short_name_length_was_read_as_2_affects_win10	2016-09-20 15:25:56.000000000 +0200
@@ -0,0 +1,34 @@
+From 2d3d006e367c8f40effc3906381563b05946bfc3 Mon Sep 17 00:00:00 2001
+From: Jeremy Allison <jra at samba.org>
+Date: Tue, 5 Apr 2016 13:07:06 -0700
+Subject: [PATCH] s3: libsmb: Fix error where short name length was read as 2
+ bytes, should be 1.
+Bug: https://bugzilla.samba.org/show_bug.cgi?id=11822
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820794
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/samba/+bug/1576449
+
+Reported by Thomas Dvorachek <tdvorachek at yahoo.com> from a Windows 10 server.
+Confirmed in MS-CIFS 2.2.8.1.7.
+
+Signed-off-by: Jeremy Allison <jra at samba.org>
+Reviewed-by: Ralph Boehme <slow at samba.org>
+
+Autobuild-User(master): Jeremy Allison <jra at samba.org>
+Autobuild-Date(master): Wed Apr  6 03:46:55 CEST 2016 on sn-devel-144
+
+(cherry picked from commit f63b9a73b03971f41947c694e6952cd1e49b67c3)
+
+Index: samba-4.2.10+dfsg/source3/libsmb/clilist.c
+===================================================================
+--- samba-4.2.10+dfsg.orig/source3/libsmb/clilist.c	2016-03-30 12:18:42.000000000 +0200
++++ samba-4.2.10+dfsg/source3/libsmb/clilist.c	2016-09-20 15:23:07.059080954 +0200
+@@ -186,7 +186,7 @@
+ 			namelen = IVAL(p,0);
+ 			p += 4;
+ 			p += 4; /* EA size */
+-			slen = SVAL(p, 0);
++			slen = CVAL(p, 0);
+ 			if (slen > 24) {
+ 				/* Bad short name length. */
+ 				return pdata_end - base;
diff -Nru samba-4.2.10+dfsg/debian/patches/series samba-4.2.10+dfsg/debian/patches/series
--- samba-4.2.10+dfsg/debian/patches/series	2016-06-01 17:10:44.000000000 +0200
+++ samba-4.2.10+dfsg/debian/patches/series	2016-09-20 15:19:40.000000000 +0200
@@ -24,3 +24,4 @@
 CVE-2016-2110-NTLMSSP-regression.patch
 ctdb-Fix-detection-of-gnukfreebsd.patch
 s3-smbd-fix-anonymous-authentication-if-signing-is-m.patch
+s3_libsmb_Fix_error_where_short_name_length_was_read_as_2_affects_win10

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE