[Pkg-scicomp-devel] Bug#455670: patch

[Ondrej Certik]

On Wed, Mar 26, 2008 at 3:56 PM, Maximiliano Curia
<maxy at gnuservers.com.ar> wrote:
> Hola Adam C Powell IV!
>
>  El 23/03/2008 a las 12:43, Ondrej Certik nos dijo:
>
>
> > thanks a lot for the patch. I don't have time to fix this. But Adam
>  > showed interest in this - could you please coordinate efforts with him?
>
>  > There is a new upstream that should be packaged - maybe they fixed the
>  > 4.3.0 build issues.
>
>  > But so far I was the main maintainer of libmesh and as to me, please
>  > feel free to upload a new revision anytime - no need to delayed NMU.
>  > Just put your changes into our svn repo, or attach the diff to the bug.
>
>  The patch I made is not perfect, it does #undef HAVE_HASH_MAP where it's needed
>  instead of fixing the configure script. To fix the configure script "the right
>  way" the changes should be made in the configure.in, and then run autoconf.
>
>  Also we would need a dependency in autotools to generate the configure script
>  in build time.
>
>  There are a few other things that might seem like a good idea to modify, the
>  package doesn't "clean" nicely, as some Makefiles refer to some non DFSG code
>  that has been removed.
>
>  The new upstream release does not fix any of this issues, but as the changes
>  are so big it makes sense to do them to the new version.
>
>  The change in the configure.in might be:
>  --- configure.in.orig   2008-03-26 11:44:14.000000000 -0300
>  +++ configure.in        2008-03-26 11:44:47.000000000 -0300
>  @@ -117,8 +117,8 @@
>   AC_CHECK_HEADERS(csignal)
>   AC_CXX_HAVE_LOCALE
>   AC_CXX_HAVE_SSTREAM
>  -AC_CHECK_HEADERS(hash_map,[],[AC_CHECK_HEADERS(ext/hash_map)])
>  -AC_CHECK_HEADERS(hash_set,[],[AC_CHECK_HEADERS(ext/hash_set)])
>  +AC_CHECK_HEADERS(ext/hash_map,[],[AC_CHECK_HEADERS(hash_map)])
>  +AC_CHECK_HEADERS(ext/hash_set,[],[AC_CHECK_HEADERS(hash_set)])
>
>   AC_CHECK_HEADERS(dlfcn.h, AC_DEFINE(HAVE_DLADDR))
>   AX_CXX_GCC_ABI_DEMANGLE
>
>  Would you care to upload the new upstream release?

If you commit it into our svn, sure I'll upload it. Otherwise I need
to find time for this first - maybe Adam will do it before me. :)

Ondrej