[Pkg-scicomp-devel] Bug#525733: FTBFS with GCC 4.4: missing #include

[Martin Michlmayr]

Package: gmsh
Version: 2.3.1.dfsg-2
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.4
Tags: patch

Your package fails to build with GCC 4.4, which has cleaned up some more
C++ headers.  You always have to #include headers directly and cannot
rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable or
gcc-4.4 from experimental.

> Automatic build of gmsh_2.3.1.dfsg-2 on em64t by sbuild/amd64 0.53
...
> g++ -O3 -I/usr/include/opencascade -DHAVE_NO_OCC_CONFIG_H -I/usr/include/mpi -DOMPI_SKIP_MPICXX -I/usr/include/freetype2 -D_THREAD_SAFE -D_REENTRANT -D_OCC64 -I../Common -I../Geo -I../Mesh -I../Post -I../Graphics -I../Numeric -I../Parser -I../Plugin -I../Fltk -I../contrib/MathEval -I../contrib/ANN/include  -c StringUtils.cpp
> StringUtils.cpp: In function 'std::string ExtractDoubleQuotedString(const char*, int)':
> StringUtils.cpp:31: error: 'EOF' was not declared in this scope
> make[2]: *** [StringUtils.o] Error 1
...
> g++ -O3 -I/usr/include/opencascade -DHAVE_NO_OCC_CONFIG_H -I/usr/include/mpi -DOMPI_SKIP_MPICXX -I/usr/include/freetype2 -D_THREAD_SAFE -D_REENTRANT -D_OCC64 -I../Common -I../Geo -I../Mesh -I../Post -I../Graphics -I../Numeric -I../Parser -I../Plugin -I../Fltk -I../contrib/MathEval -I../contrib/ANN/include  -c PViewDataIO.cpp
> PViewDataIO.cpp: In member function 'virtual bool PViewData::writeSTL(std::string)':
> PViewDataIO.cpp:13: error: 'fopen' was not declared in this scope
> PViewDataIO.cpp:26: error: 'fprintf' was not declared in this scope
> PViewDataIO.cpp:65: error: 'fclose' was not declared in this scope
> PViewDataIO.cpp: In member function 'virtual bool PViewData::writeTXT(std::string)':
> PViewDataIO.cpp:71: error: 'fopen' was not declared in this scope
> PViewDataIO.cpp:83: error: 'fprintf' was not declared in this scope
> PViewDataIO.cpp:90: error: 'fprintf' was not declared in this scope
> PViewDataIO.cpp:92: error: 'fprintf' was not declared in this scope
> PViewDataIO.cpp:94: error: 'fprintf' was not declared in this scope
> PViewDataIO.cpp:97: error: 'fclose' was not declared in this scope
> make[2]: *** [PViewDataIO.o] Error 1
> make[2]: Leaving directory `/build/tbm/gmsh-2.3.1.dfsg/Post'
etc

--- contrib/Chaco/main/Gmsh_printf.cpp~	2009-04-26 20:29:45.000000000 +0000
+++ contrib/Chaco/main/Gmsh_printf.cpp	2009-04-26 20:29:53.000000000 +0000
@@ -3,6 +3,7 @@
 // See the LICENSE.txt file for license information. Please report all
 // bugs and problems to <gmsh at geuz.org>.
 
+#include <cstdio>
 #include <cstring>
 #include "GmshMessage.h"
 
--- Common/StringUtils.cpp~	2009-04-26 20:28:33.000000000 +0000
+++ Common/StringUtils.cpp	2009-04-26 20:29:11.000000000 +0000
@@ -7,6 +7,7 @@
 #include <sys/cygwin.h>
 #endif
 
+#include <stdio.h>
 #include "StringUtils.h"
 #include "GmshMessage.h"
 
--- Post/PViewDataIO.cpp~	2009-04-26 20:28:52.000000000 +0000
+++ Post/PViewDataIO.cpp	2009-04-26 20:28:58.000000000 +0000
@@ -3,6 +3,7 @@
 // See the LICENSE.txt file for license information. Please report all
 // bugs and problems to <gmsh at geuz.org>.
 
+#include <stdio.h>
 #include <string.h>
 #include "GmshMessage.h"
 #include "Numeric.h"
--- Fltk/messageWindow.cpp~	2009-04-26 20:29:27.000000000 +0000
+++ Fltk/messageWindow.cpp	2009-04-26 20:29:34.000000000 +0000
@@ -3,6 +3,7 @@
 // See the LICENSE.txt file for license information. Please report all
 // bugs and problems to <gmsh at geuz.org>.
 
+#include <stdio.h>
 #include <string.h>
 #include <FL/Fl_Box.H>
 #include <FL/Fl_Return_Button.H>
--- Fltk/aboutWindow.cpp~	2009-04-26 20:31:20.000000000 +0000
+++ Fltk/aboutWindow.cpp	2009-04-26 20:31:28.000000000 +0000
@@ -3,6 +3,7 @@
 // See the LICENSE.txt file for license information. Please report all
 // bugs and problems to <gmsh at geuz.org>.
 
+#include <stdio.h>
 #include <FL/Fl_Browser.H>
 #include <FL/Fl_Box.H>
 #include <FL/Fl_Button.H>

-- 
Martin Michlmayr
http://www.cyrius.com/