[Pkg-scicomp-devel] Bug#487638: opencv patch for libavcodec/ffmpeg api

[Gijs Molenaar]

Hi everyone,

I'm not experienced with C programming. The patch I applied just fixes  
some include paths, and also includes a patch adapted from Gentoo. I  
think I posted a link to the patch in the bugreport comments.

  - gijs


Op 7 jul 2009, om 08:54 heeft Thomas Viehmann het volgende geschreven:

> Hi Gijs and Nicolau,
>
> (And hi Raphael, you are the last NMUer. Maybe you are interested in  
> uploading a fixed package with a revised version of Gijs patch, if  
> not, maybe Paul or Ondrej want to.)
>
> first, and most importantly, thanks for looking into fixing this  
> problem and sharing your patch with Debian.
>
> Just a quick technical comment:
> The use of a static variable for the scaling context seems bogus.  
> Similarly, allocating a context in icvRetreiveFrame seems too often.  
> Also, not releasing it looks wrong.
>
> What should be done instead is amend the (internal) struct  
> CvCaptureAVI_FFMPEG with the SwsContext (I'd name the struct member  
> sws_context rather than img_conver_context, too, but that could be  
> me), AFAICT this should not change the exported ABI. Then initialize  
> the context in icvOpenAVI_FFMPEG and give it back in  
> icvCloseAVI_FFMPEG.
>
> This is, of course, along the lines of "don't use static vars where  
> you should not".
>
> I have not reviewed any other aspect of the patch.
>
> Again, thanks for looking into fixing this bug. Let me know if I can  
> be of further assistance.
>
> Kind regards
>
> T.
> -- 
> Thomas Viehmann, http://thomas.viehmann.net/