[Pkg-scicomp-devel] Bug#538578: paraview: FTBFS with new source format 3.0 (quilt): improper filename in patch hunk

[hertzog at debian.org]

Package: paraview
Version: 3.4.0-4
Severity: wishlist
Usertags: 3.0-quilt-by-default

To prepare a possible switch to the new source package format "3.0
(quilt)" [1], I converted all source packages and rebuilt the packages
afterwards to see what breaks, and paraview does break. To reproduce the
problem you can do this:
$ apt-get source paraview
$ mkdir -p paraview-3.4.0/debian/source
$ echo "3.0 (quilt)" >paraview-3.4.0/debian/source/format
$ dpkg-source -b paraview-3.4.0
$ dpkg-source -x paraview_3.4.0-4.dsc
$ cd paraview-3.4.0 && debuild -us -uc

In this process, if the .diff.gz contains changes to upstream files,
dpkg-source will have created a corresponding patch in
debian/patches/debian-changes-3.4.0-4 and will have registered that
patch in a quilt series (debian/patches/series, it is created if needed).
All the patches listed in the "series" file are applied directly during
the extraction (dpkg-source -x). quilt itself is used if available (and
will thus lead to the creation of the .pc directory), otherwise
dpkg-source applies the patches by itself. For more information about the
new source package format see the manual page dpkg-source(1).

In the case of paraview, one of the patches contain improper
references to some files. Either the filename is absolute or it lacks
a top-directory (all patches are applied with patch -p1 so filenames
in patch must contain a top-level directory):

Wrong:
--- build.xml   2003-07-07 17:55:08.000000000 +0200
+++ build.xml   2007-09-04 15:19:31.000000000 +0200

--- /somewhere/build.xml   2003-07-07 17:55:08.000000000 +0200
+++ /someplace/build.xml   2007-09-04 15:19:31.000000000 +0200

Correct:
--- a/build.xml   2003-07-07 17:55:08.000000000 +0200
+++ b/build.xml   2007-09-04 15:19:31.000000000 +0200

Cheers,

[1] http://wiki.debian.org/Projects/DebSrc3.0