packaging dnsmap
Gianfranco Costamagna
locutusofborg at debian.org
Mon Jan 2 17:32:43 UTC 2017
Hello
>l) Patch Makefile: The makefile is missing CPPFLAGS, LFDLAGS and the CFLAGS is being overriden (which causes a useless -dbgsym package), please have a look at[5] >for hints on how to fix that. After that you may also add "export DEB_BUILD_MAINT_OPTIONS = hardening=+all" at d/rules in order to enable bindnow.
p) patch makefile to have "make install" point to $(DESTDIR)/$(BINDIR) with BINDIR defined probably in rules file.
This way you will use the upstream make install target, not a Debian copy-pasted one
>m) Rename dnsmap-bulk.sh to dnsmap-bulk: We are encouraged not to ship script files with language extensions, you can read more about this here[6].
("p" should fix also this issue)
also, I like stuff such as
CC?=gcc
in Makefile
you can read the above as:
define CC=gcc if not already defined
this way something like
CC=clang dpkg-buildpackage/make will work too.
thanks Samuel for the really nice review!
(flags were the blocking points for me, thanks for catching them!)
G.
More information about the Pkg-security-team
mailing list