[pkg] CurveDNS - review

[Stéphane Neveu]

Hi Lukas,

2017-06-29 10:03 GMT+02:00 Lukas Schwaighofer <lukas at schwaighofer.name>:
> Hi,
>
> debian/copyright file has a few syntax errors.  You can use the
> `cme` tool to help you spot the errors.
>
> $ cd path/to/curvedns/package/dir
> $ cme check dpkg
> File debian/copyright line 27 has a syntax error:
> (...)
>

I've corrected the error but now I have another one and I do not know
what it means :
checking data
Configuration item 'copyright Files:"*" License short_name' has a wrong value:
       Undefined mandatory value.


>
> I also have a question: can you explain the options you're using in
> debian/source/options?  In which cases are they needed?
>

It shouldn't be here, deleted :)

>
> I think we've covered the technical part of the package now.  The
> documentation should be improved a bit:
> * man pages should only cover the binary itself and not mention
>   variables from /etc/default/$NAME that have nothing to do with the
>   binary
> * README.Debian should cover the DNS setup to have DNScurve operational
>   a bit as well.  It should offer enough information to someone who
>   knows how to operate an authoritative DNS server to setup their domain
>   correctly. After you've made a successful test setup you should be
>   able to write this…
>
> I'm also thinking about re-organizing how the information
> in /etc/curvedns/ is presented.  At the moment it's not clear that only
> one file (the private key) is configuration and the others are
> information for the operator to setup his DNS zone.  One idea would be
> to create an /etc/curvedns/README file that contains the public key (in
> the two different encodings) and explains this.  What do you think
> would be best?
>

I have also
- updated the manpages to remove any references to the
/etc/default/cirvedns file.
- updated curvedns.README.Debian, tell me if it's sound better to you now ?
- merged both pubkey formats into one /etc/curvedns/README file
Do I need to add some comments here or would it be redondant with the
README.Debian ?
If yes, maybe I should save both public keys in a file called pubkey
for example and add a static README here ?


> Regards
> Lukas

Regards,

Stephane