[pkg] CurveDNS - review

Lukas Schwaighofer lukas at schwaighofer.name
Sat Jul 1 12:43:51 UTC 2017


Hi Stephane,

I've made a thorough pass over the package again and made a few
changes, most of them minor things like wording.

Noteworthy stuff I've changed:
* I've removed README and INSTALL again as they are not useful for the
  Debian package (I know you included them at my request earlier, sorry
  about that)
* I've cleaned a bit of unnecessary stuff from the makefile and
  re-introduced the `distclean` target (used by dh_clean to remove
  the compiled files)
* I've changed debian/rules so that the generated man pages are cleaned
  as well (the clean target now properly removes everything that was
  generated)
* Changes to postinst:
  - /var/lib/curvedns and the curvedns user is already cleaned on
    "remove" (it's not configuration…)
  - the configuration in /etc/curvedns/ is still only cleaned on "purge"
* I've changed the man pages a bit.  In particular I've removed the
  example output (I'm always afraid someone will copy it and use it as
  their key…)

Please review my changes.  I have no more comments now :) .

If you are happy with my changes then I suggest you update the
timestamp in debian/changelog and then ask if one of the DDs here is
willing to review (and hopefully sponsor) the package.

Regards
Lukas

PS: Don't forget to submit a pull request upstream to fix the spelling
    mistakes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170701/06c82bd3/attachment.sig>


More information about the Pkg-security-team mailing list