Ask for review

[Marcos Fouces]

El 16/06/17 a las 14:59, Raphael Hertzog escribió:
> Now reviewing autolog:
> - "Deleted unnecessary files in source tarball (*.spec and a binary)"
>    => why was this important? and if it's important, then you want
>    to automate this for future releases by adding a Files-Excluded
>    field in debian/copyright so that they are excluded automatically
>    when you run uscan.
This is a nit-picky change on my side :-) You are right. Anyway, 
upstream is dead almost 20 years ago so there won't be future releases.
> - the clean rule fails when the package is already clean:
>
> $ gbp buildpackage --git-builder=sbuild
> gbp:warning: Pristine-tar branch "pristine-tar" not found
> gbp:info: Exporting 'HEAD' to '/home/rhertzog/deb/pkg/build-area/autolog-tmp'
> gbp:info: Moving '/home/rhertzog/deb/pkg/build-area/autolog-tmp' to '/home/rhertzog/deb/pkg/build-area/autolog-0.40+debian'
> dh clean
>     dh_testdir
>     dh_auto_clean
> 	make -j1 clean
> make[1]: Entering directory '/home/rhertzog/deb/pkg/build-area/autolog-0.40+debian'
> rm autolog
> rm: cannot remove 'autolog': No such file or directory
> Makefile:25: recipe for target 'clean' failed
> make[1]: *** [clean] Error 1
>
> => the upstream Makefile needs to be patched to use "rm -f" instead of "rm"

The former maintainer already fixed this issue with in 
d/patches/01_Makefile.patch

> - the various preinst/postinst scripts manually handle the update-rc.d calls, I would suggest
> to rely on dh_installinit by copying our patched init script in debian/autolog.init
Done hopefully right.
> - at the same time you could create the appropriate systemd service file
Done.

>
> - the rest is looking good
OK, thanks for the review.

Greetings,
Marcos