new version wifite

[Lukas Schwaighofer]

Hi Daniel,

On Sat, 2 Sep 2017 13:12:50 -0500
Daniel Echeverry <epsilon77 at gmail.com> wrote:
> Some time ago, wifite was updated with minor changes[1]. I updated the
> git repo with theses changes[2], Could someone check it out?

I took a look and updating seems reasonable.  However, you should think
about your versioning scheme.  The Debian versions up to now were called
   2.0r85-1
   2.0.85~gitedbdedd14-1
and you want to call the new one
   2.0.85+git918a499786-1

That doesn't look like there is a system to that.  I'd suggest you
adopt a schema that includes the date of the commit as YYYYMMDD (before
a short version of the git sha1).  As the REVISION variable has been
set to 87, an idea for the version could be:
   2.0.87+git20170515.918a499-1


Other cleanup/nitpick suggestions:
* Remove version depends from python, and the X-Python-Version [1] from
  d/control; there is only one python2 version left in the archive
  (even oldoldstable has 2.7).
* There's policy 4.1.0 now
* Link to copyright format in debian/copyright can be https


And finally I have a request to make reviewing your changes easier:
Please don't make any changes to debian/* files as part of the merge
commit.  If you make those changes in separate commits after the merge,
their diffs are a lot easier to read (at least for me).

Regards
Lukas


[1] https://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-specifying_versions