intetsim review (Re: ITP: inetsim)
yoo z
zouyoo at outlook.com
Thu Oct 5 11:19:31 UTC 2017
Hi Lukas
I changed the repo according to what you've mentioned and you can look
at it here
https://github.com/Z-Y00/inetsim
I think we should ask the upstream author about the .exe files
because this is a tool for malware analysis, it included these harmless
samples.
thus to simulate the download of harmful malwares, which is a key part
of the simulation.
I guess it would be fine if just let the users add these samples by
themself.
> Looking at the contents of the binary package, I don't like the look of
> the /usr/share/inetsim/contrib directory:
> * it contains a windows binary and some source files which probably
> are not needed
> * it contains an init script; should this be installed?
I've added the inetsim.init script now, which is the same with
contrib/init.d.inetsim,
> * in any case, the contents of this directory and its use should be
> explained (also for filter-logs.pl and gen_control.pl); I would
> suggest creating a README.Debian for that
>
these two scripts were written by the upstream author to simplify the
usage (one for log file. one for ip config)
I'll add a README.Debian after upstream give us advice about these files
Cheers,
GengYu
More information about the Pkg-security-team
mailing list