intetsim review (Re: ITP: inetsim)

[GengYu Rao]

Hi lukas,

On Wednesday, November 15, 2017 04:02 PM, Lukas Schwaighofer wrote:
> On Wed, 15 Nov 2017 03:57:20 +0000
> GengYu Rao <zouyoo at outlook.com> wrote:
>
>>>> The easier way is to add the helper script and cd there,
>>>> like the init script. This would avoid many problems.
>> when launching by init script the cwd will be changed
>> to /usr/share/inetsim but if launched from console the cwd wouldn't
>> be that, and it will try to use
>> ./conf, ./data, ./log  ./report directories relative to the cwd.
> I would argue that this makes sense for inetsim:  If you want to run it
> from the command line to test something, you would do that in a new
> folder and make a configuration specifically for that.  The
> data/log/report will then not "mix" with other experiments.
well, this is true. but i think it is also good to install just like 
upstream
or kali. otherwise, users may got puzzled for different packages
have different locations of files. And there are many tutorials saying
the files are at certain places, users many look at those online.

so I cc the upstream for advice here:)

 >If you want to run it from the command line to test something,
 >you would do that in a new folder
you can specific the location you want instead of cwd via console
   --config <configuration file>
    The configuration file to use, default is conf/inetsim.conf in cwd
   --data-dir <data directory>
   --log-dir <log directory>
   --report-dir <report directory>
Just use command line to specific the location will be okey.
>> So in order to let it use the same files when launched from different
>> ways the easier way is to add the helper script and cd
>> to /usr/share/inetsim Or we need to patch it, to let it
>> use ./conf ./data ./log ./report from one place
> If we want them to always log to those directories and use the
> respective configuration files, we can patch lib/INetSim/Config.pm
> instead.
Regards,
GengYu Rao