ITP: inetsim

Lukas Schwaighofer lukas at schwaighofer.name
Tue Feb 20 22:21:00 UTC 2018


Hi GengYu,

I think the package is fine now, I only have a few small beautification
suggestions:

* You still have lintian informational tags
  "package-contains-empty-directory" which you might want to get rid of.
* debian/inetsim.postrm has a trailing space (end of rm command).
* debian/rules: It's conventional to have an empty line between the
  targets to improve readability.
* debian/inetsim.postinst: The adduser command has `--quiet` twice (I
  think this was my mistake actually…) so you can remove one.
* debian/inetsim.{prerm,postinst}: `exit 0` at the end is not required
  (and pretty useless in combination with `set -e`) so you can remove
  it.

Good luck finding a sponsor!

Regards
Lukas



More information about the Pkg-security-team mailing list