New t50 release

[Samuel Henrique]

Hello Marcos,

There's still one regression left to fix which i didn't catch up earlier.

Please have a look at this upstream's commit
https://github.com/fredericopissarra/t50/commit/607b4174b4dc1bec6439c8efca50876f145c5a40#diff-67e997bcfdac55191033d57a16d1408aL22
which broke our usage of CFLAGS by overriding them.

I'm sure you're familiar with this problem, as it's the same as the LDFLAGS
one, which you fixed already.

Once you push a patch, i'll sponsor your package.

Thanks for your work.

2018-03-15 19:38 GMT-03:00 Marcos Fouces <marcos.fouces at gmail.com>:

> Hello Samuel
>
> Thanks for review. I did all your recommendations.
>
> I decided to add some (pretty useless, really) upstream metadata to make
> Lintian happier. Perhaps it is not pretty well suited for the software we
> package here... We should discuss it.
>
> Greetings.
>
> Marcos
> El 14/03/18 a las 02:15, Samuel Henrique escribió:
>
> Hello Marcos,
>
> Looking through your commits, i have some comments:
>
> * Update copyright year: Once you update the debian entry on d/copyright
> it's recommended to update the all the entries, not just yours. Please
> update with the other contributions (there's at least Raphäel's,
> Gianfranco's, and mines which need to be updated too).
>
> * Rework patches for new upstream release: You dropped a patch here which
> was sent and fixed upstream, please try to make these kind of things on
> separate commits and mention it on d/changelog. I won't ask you to split
> the commits now, since that would require a git's history change, but
> please add an entry specifying which patches were updated and which were
> dropped. You can have a look at the 5.6.6-1 changelog so you can get an
> idea.
>
> * Add some upstream metadata: I'm not sure you should worry with DEP12, it
> has been a draft for some years[0], it looks like its most useful for
> packages which deals with citations and i'm not sure we are making use of
> any feature of it. It may be not worth to maintain d/upstream/metadata for
> our packages. I won't ask you to remove it though, i'll leave the decision
> up to you.
>
> Regardless of this, nice work.
>
> I will reply future messages on this thread faster now that i already
> started reviewing your package.
>
> I will also have another deeper look just to be sure i didn't miss
> anything, but i'm pretty sure i can upload the package once you fix
> d/changelog and d/copyright.
>
> [0]http://dep.debian.net/deps/dep12/
>
> 2018-03-11 23:44 GMT-03:00 Samuel Henrique <samueloph at gmail.com>:
>
>> Hello Marcos,
>>
>> Sure, I can review and sponsor your work, just give me a couple of days
>> (i'm a little busy right now). But i don't mind if someone else sponsor it,
>> as always :)
>>
>> 2018-03-11 14:13 GMT-03:00 Marcos Fouces <marcos.fouces at gmail.com>:
>>
>>> Hello
>>>
>>> I just uploaded a new t50 [*]release. Could you please check and (if
>>> apropiate) sponsor it?
>>>
>>> Greetings,
>>>
>>> Marcos
>>>
>>> [*] https://salsa.debian.org/pkg-security-team/t50
>>>
>>
>>
>>
>> --
>> Samuel Henrique <samueloph>
>>
>
>
>
> --
> Samuel Henrique <samueloph>
>
>
>


-- 
Samuel Henrique <samueloph>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20180317/cceada4f/attachment.html>