<div dir="ltr"><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">Hi all,<br><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">I've just updated the patch description, i sent it upstream, let's see if he agrees.<br><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">I'm currently waiting to get an advocacy for DM, when i got one i believe it'll be easier to work with t50 because i will be allowed to sign your changes, Marco.<br><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">By the way, Marco, is there a problem if i make some changes on the changelog entry?<br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">We have now:<br><br>"* Patch to avoid various FTBS. Thanks to Gianfranco Costamagna"<br><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">I would like to cite the patch name, like:<br><br>"* debian/patches/disable-linux-test.patch: Create patch to avoid FTBS on<br> systems where host_os != linux-gnu. Thanks to Gianfranco Costamagna."<br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">It's a good practice to cite which files were created/removed/changed on the changelog, in order to make it easier to track changes. You can suggest an alternative if you don't like the example above.<br><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">There's also a little problem with the entry from 5.6.7-1, something went wrong when you formatted the entry, there's two unneeded "[ Marcos Fouces ]" entries, i'm fixing this one right now, so i just need confirmation from the above.<br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default"><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">Currently we need someone to sign and send 5.6.7-2.<br><br><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><span style="font-family:verdana,sans-serif"><span style="color:rgb(102,102,102)">Samuel Henrique O. P. [samueloph]</span></span></div></div></div></div></div>
<br><div class="gmail_quote">2016-09-05 13:45 GMT-03:00 Marcos Fouces <span dir="ltr"><<a href="mailto:mfouces@yahoo.es" target="_blank">mfouces@yahoo.es</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<br>
I just added a patch with Gianfranco suggestion.<br>
<br>
Can someone test and upload. I tested with a pbuilder chroot but only for sid with am64 and linux.<br>
<br>
Cheers. Marcos<br>
<br>
<br>
El 05/09/16 a las 08:11, Gianfranco Costamagna escribió:<div class="HOEnZb"><div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Samuel, Marcos<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
uploaded,<br>
</blockquote>
<br>
seems that a new check makes it FTBFS on armhf, armel, mips64el, x32 and probably more.<br>
<br>
+# For now, this system will compile ok only on Linux.<br>
+if test "${host_os}" != "linux-gnu"; then<br>
+ AC_MSG_ERROR([T50 will compile only on Linux systems.])<br>
+fi<br>
<br>
this check makes it fail when host_os is equal e.g. to:<br>
host_os='linux-gnuabi64'<br>
host_os='linux-gnux32'<br>
host_os='linux-gnueabihf'<br>
host_os='linux-gnueabi'<br>
<br>
I tried this patch in a qemu armhf environment:<br>
-if test "${host_os}" != "linux-gnu"; then<br>
- AC_MSG_ERROR([T50 will compile only on Linux systems.])<br>
+if test "${host_os}" != "linux-gnu" && test "${host_os}" != "linux-gnueabi" !! test "${host_os}" != "linux-gnueabihf"; then<br>
+ AC_MSG_ERROR([T50 will compile only on Linux systems, ${host_os} detected])<br>
<br>
<br>
and it works, but I'm really sure this isn't the right fix, unfortunately I'm not an autoconf man.<br>
Honestly I would drop that check in Debian, since the build is already restricted to linux/only OS.<br>
<br>
let me know and I'll sponsor it if needed,<br>
<br>
thanks,<br>
<br>
G.<br>
<br>
</blockquote>
<br>
<br></div></div><div class="HOEnZb"><div class="h5">
______________________________<wbr>_________________<br>
Pkg-security-team mailing list<br>
<a href="mailto:Pkg-security-team@lists.alioth.debian.org" target="_blank">Pkg-security-team@lists.alioth<wbr>.debian.org</a><br>
<a href="https://lists.alioth.debian.org/mailman/listinfo/pkg-security-team" rel="noreferrer" target="_blank">https://lists.alioth.debian.or<wbr>g/mailman/listinfo/pkg-securit<wbr>y-team</a><br>
</div></div></blockquote></div><br></div>