<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_default" style="font-family:tahoma,sans-serif;color:rgb(0,0,0)"><span class="gmail-m_-6959567979135035810gmail-im">>That's nice, i will wait for Gianfranco's reply and then commit a gitignore containing only the ".pc" folder.<br>
><br>
>As you're a DM with upload rights to aircrack-ng, i think you can
upload it yourself (this aircrack-ng new release) after reviewing my
changes. And if you don't >have the time, then I would ask for
Gianfranco's review and upload.<br>
<br>
<br>
</span>feel free to do whatever you prefer :)</div></blockquote><div> </div><div class="gmail_extra"><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0);display:inline" class="gmail_default">Cool, i'm gonna see what to do.</div> <br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default"><span class="gmail-m_-6959567979135035810gmail-im">>From my POV, there's two things left to discuss:<br>
><br>
>1) The python problem:<br>
</span><span class="gmail-m_-6959567979135035810gmail-im">>I'm not really sure if that script (and
others) should be there, and even if that's ok, do we need to add a
python depends just for them? Can we ship the script and >left the
python dependency out, as they're not needed for aircrack-ng usage?<br>
<br>
<br>
</span>it might make sense, and Python is somewhat installed almost everywhere already (I mean, I don't<br>
think there is an user needing only aircrack-ng in a almost empty system, and needs that single<br>
Python script)</div></blockquote><br><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">Nice, so if Carlos agrees, and we don't get any objections, this problem may be considered fixed, as we won't depend on python.</div><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default"><span class="gmail-m_-6959567979135035810gmail-im">>Please have a look at <a href="https://trac.aircrack-ng.org/ticket/1680" rel="noreferrer" target="_blank">https://trac.aircrack-ng.org/t<wbr>icket/1680</a> in order to understand the problem.<br>
><br>
>There are two possible workarounds (i listed them on the last comment):<br>
><br>
>* Remove the Harkonen test (which we're doing right now and its bad
because the Harkonen decrypt doesn't work deterministically).<br>
><br>
>* Remove the fortify hardening flag (which is bad because it will disable fortify for all the binaries)<br>
>The two problems are already ~fixed~ with what i believe are the
best workarounds, if you disagree, please feel free to reply and push
your changes :)<br>
<br>
<br>
</span>there is a patch on that track (github issue), did you try it?<br>
You already know this, but:<br>
Disabling a test means that in the real world this use-case will make the program segfault<br>
(I don't know how many people will need such code).<br>
Disabling hardening seems bad, but not so much as disabling the test.<br>
<br>
<br>
Asking for advices on -mentors or whatever might help you in finding the root cause and fix it<br>
(also bisecting the issue with git bisect might help)</div></blockquote><div><br><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">If the patch you mentioned is this one (<a href="https://github.com/aircrack-ng/aircrack-ng/pull/57">https://github.com/aircrack-ng/aircrack-ng/pull/57</a>), i didn't test it because the discussion made me think that its better to wait for upstream ack. in this case.<br><br>I think we don't need git bissect as we already know which commit showed us the bug (<a href="https://github.com/aircrack-ng/aircrack-ng/commit/37af2dfcccedf667e4a8747ee897ac9d9269b1e9">https://github.com/aircrack-ng/aircrack-ng/commit/37af2dfcccedf667e4a8747ee897ac9d9269b1e9</a>), i say "showed us" because it looks like the problem was already there (my bet is that its a problem with memcpy or memset). Using git bisect to get the exact problem wouldn't be helpful since we have no idea about when the actual bug was commited (no commit-range to look for).<br></div><br><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">About cutting off the test vs. disabling fortify, let's see what Carlos thinks, and if we still have doubts, then i can ask help on mentors (but i think we can sort this one out with some C skills :) ).<br></div><br></div><div style="font-family:tahoma,sans-serif;color:rgb(0,0,0)" class="gmail_default">Thanks for your help, also, i didn't know the git-bissect tool, learned something today.</div><br clear="all"><div><div class="gmail-m_-6959567979135035810gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span style="font-family:verdana,sans-serif"><span style="color:rgb(102,102,102)">Samuel Henrique <samueloph></span></span></div></div></div></div></div></div></div>
</div></div>