<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>OK, fixed now.</p>
<p>I also did not catch it up because Lintian does not complaint
about it. I don't know the reason.<br>
</p>
Greetings, <br>
Marcos<br>
<br>
<div class="moz-cite-prefix">El 18/03/18 a las 02:34, Samuel
Henrique escribió:<br>
</div>
<blockquote type="cite"
cite="mid:CABwkT9pxmBekyPnYZq9aCo+DKiTXDEkUFGqKRWuxZA=XQzArWg@mail.gmail.com">
<div dir="ltr">
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">I
forgot one important tip:<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">To
check this kind of problems, you can use blhc, like:<br>
blhc -all t50_5.7.1-1_amd64.build<br>
<br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2018-03-17 22:32 GMT-03:00 Samuel
Henrique <span dir="ltr"><<a
href="mailto:samueloph@gmail.com" target="_blank"
moz-do-not-send="true">samueloph@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Hello
Marcos,<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">There's
still one regression left to fix which i didn't catch up
earlier.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Please
have a look at this upstream's commit <a
href="https://github.com/fredericopissarra/t50/commit/607b4174b4dc1bec6439c8efca50876f145c5a40#diff-67e997bcfdac55191033d57a16d1408aL22"
target="_blank" moz-do-not-send="true">https://github.com/<wbr>fredericopissarra/t50/commit/<wbr>607b4174b4dc1bec6439c8efca5087<wbr>6f145c5a40#diff-<wbr>67e997bcfdac55191033d57a16d140<wbr>8aL22</a>
which broke our usage of CFLAGS by overriding them.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">I'm
sure you're familiar with this problem, as it's the same
as the LDFLAGS one, which you fixed already.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Once
you push a patch, i'll sponsor your package.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Thanks
for your work.<br>
</div>
</div>
<div class="gmail_extra">
<div>
<div class="h5"><br>
<div class="gmail_quote">2018-03-15 19:38 GMT-03:00
Marcos Fouces <span dir="ltr"><<a
href="mailto:marcos.fouces@gmail.com"
target="_blank" moz-do-not-send="true">marcos.fouces@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hello Samuel</p>
<p>Thanks for review. I did all your
recommendations. <br>
</p>
<p>I decided to add some (pretty useless,
really) upstream metadata to make Lintian
happier. Perhaps it is not pretty well suited
for the software we package here... We should
discuss it.</p>
<p>Greetings. <br>
</p>
<p>Marcos<br>
</p>
<div
class="m_-8031394806160776757m_7494902759609511271moz-cite-prefix">El
14/03/18 a las 02:15, Samuel Henrique
escribió:<br>
</div>
<div>
<div class="m_-8031394806160776757h5">
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Hello
Marcos,<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Looking
through your commits, i have some
comments:<br>
<br>
* Update copyright year: Once you
update the debian entry on d/copyright
it's recommended to update the all the
entries, not just yours. Please update
with the other contributions (there's
at least Raphäel's, Gianfranco's, and
mines which need to be updated too).<br>
<br>
* Rework patches for new upstream
release: You dropped a patch here
which was sent and fixed upstream,
please try to make these kind of
things on separate commits and mention
it on d/changelog. I won't ask you to
split the commits now, since that
would require a git's history change,
but please add an entry specifying
which patches were updated and which
were dropped. You can have a look at
the 5.6.6-1 changelog so you can get
an idea.<br>
<br>
* Add some upstream metadata: I'm not
sure you should worry with DEP12, it
has been a draft for some years[0], it
looks like its most useful for
packages which deals with citations
and i'm not sure we are making use of
any feature of it. It may be not worth
to maintain d/upstream/metadata for
our packages. I won't ask you to
remove it though, i'll leave the
decision up to you.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Regardless
of this, nice work.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">I
will reply future messages on this
thread faster now that i already
started reviewing your package.<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">I
will also have another deeper look
just to be sure i didn't miss
anything, but i'm pretty sure i can
upload the package once you fix
d/changelog and d/copyright.<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)"><br>
[0]<a
href="http://dep.debian.net/deps/dep12/"
target="_blank"
moz-do-not-send="true">http://dep.debian.net/deps/<wbr>dep12/</a><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2018-03-11
23:44 GMT-03:00 Samuel Henrique <span
dir="ltr"><<a
href="mailto:samueloph@gmail.com"
target="_blank"
moz-do-not-send="true">samueloph@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div dir="ltr">
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Hello
Marcos,<br>
<br>
</div>
<div class="gmail_default"
style="font-family:tahoma,sans-serif;color:rgb(0,0,0)">Sure,
I can review and sponsor your
work, just give me a couple of
days (i'm a little busy right
now). But i don't mind if
someone else sponsor it, as
always :)<br>
</div>
</div>
<div class="gmail_extra">
<div>
<div
class="m_-8031394806160776757m_7494902759609511271h5"><br>
<div class="gmail_quote">2018-03-11
14:13 GMT-03:00 Marcos
Fouces <span dir="ltr"><<a
href="mailto:marcos.fouces@gmail.com" target="_blank"
moz-do-not-send="true">marcos.fouces@gmail.com</a>></span>:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px #ccc
solid;padding-left:1ex">
<div text="#000000"
bgcolor="#FFFFFF">
<p>Hello</p>
<p>I just uploaded a new
t50 [*]release. Could
you please check and
(if apropiate) sponsor
it?</p>
<p>Greetings, <br>
</p>
<p>Marcos</p>
<p>[*] <a
class="m_-8031394806160776757m_7494902759609511271m_847298691323410976m_218821088122180448moz-txt-link-freetext"
href="https://salsa.debian.org/pkg-security-team/t50" target="_blank"
moz-do-not-send="true">https://salsa.debian.org/pkg-s<wbr>ecurity-team/t50</a><br>
</p>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
</div>
</div>
<span
class="m_-8031394806160776757m_7494902759609511271HOEnZb"><font
color="#888888">-- <br>
<div
class="m_-8031394806160776757m_7494902759609511271m_847298691323410976gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr"><span
style="font-family:verdana,sans-serif"><span
style="color:rgb(102,102,102)">Samuel
Henrique
<samueloph></span></span></div>
</div>
</div>
</div>
</div>
</div>
</font></span></div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div
class="m_-8031394806160776757m_7494902759609511271gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr"><span
style="font-family:verdana,sans-serif"><span
style="color:rgb(102,102,102)">Samuel Henrique <samueloph></span></span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
</div>
</div>
<span class="HOEnZb"><font color="#888888">-- <br>
<div class="m_-8031394806160776757gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr"><span
style="font-family:verdana,sans-serif"><span
style="color:rgb(102,102,102)">Samuel
Henrique <samueloph></span></span></div>
</div>
</div>
</div>
</div>
</div>
</font></span></div>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div>
<div dir="ltr"><span
style="font-family:verdana,sans-serif"><span
style="color:rgb(102,102,102)">Samuel Henrique
<samueloph></span></span></div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>