[Pkg-shadow-commits] r807 - trunk/debian/patches

[Christian Perrier]

Author: bubulle
Date: 2006-01-15 15:26:20 +0000 (Sun, 15 Jan 2006)
New Revision: 807

Modified:
   trunk/debian/patches/484_su-p_preserve_PATH
   trunk/debian/patches/485_shelle-exitcodes
Log:
Reimplement xrtng changes


Modified: trunk/debian/patches/484_su-p_preserve_PATH
===================================================================
--- trunk/debian/patches/484_su-p_preserve_PATH	2006-01-15 15:21:24 UTC (rev 806)
+++ trunk/debian/patches/484_su-p_preserve_PATH	2006-01-15 15:26:20 UTC (rev 807)
@@ -6,13 +6,23 @@
 using global variable "newenvp" for passing environment, while in other
 places global variable "environ" is used/assumed.
 
-Patch makes several calls to pass environment explicitly.
+Patch replaces shell() calls in su.c with shelle() ones, which explicitly
+pass environment as 3rd parameter.
 
 Status wrt upstream: reported, but not yet accepted.
 
-Note: On Linux, shell() doesn't provide anything. Just an execv would be
-simplier.
+Note: On Linux, shell() doesn't provide anything significant. Just an
+execv could be simplier.
+shell/shelle() vs. execv() differences:
+1. exits/returns EINVAL when 1st argument (name of executable) is NULL
+2. when ARGV is NULL, forges argv[0] by prepending "-" to image name
+3. prints "Executing shell ..." message when built with DEBUG
+4. handles non-Linux ENOEXEC
+5. prints "Cannot execute ..." error message when execle() fails
 
+(1) probably isn't possible when calling shell() from su.c -- it's always
+being provided with executable filename.
+
 Index: shadow-4.0.14/src/su.c
 ===================================================================
 --- shadow-4.0.14.orig/src/su.c	2006-01-15 11:14:14.000000000 +0200

Modified: trunk/debian/patches/485_shelle-exitcodes
===================================================================
--- trunk/debian/patches/485_shelle-exitcodes	2006-01-15 15:21:24 UTC (rev 806)
+++ trunk/debian/patches/485_shelle-exitcodes	2006-01-15 15:26:20 UTC (rev 807)
@@ -1,3 +1,7 @@
+Goal: eliminate usage of old shell() and introduce E_CMD_{NOEXEC|NOTFOUND}
+
+Status wrt upstream: discussed, but not explicitly reported or accepted yet.
+
 Index: shadow-4.0.14/src/sulogin.c
 ===================================================================
 --- shadow-4.0.14.orig/src/sulogin.c	2005-12-06 23:25:00.000000000 +0200