[Pkg-shadow-commits] r1848 - in upstream/trunk: . src

[nekral-guest at alioth.debian.org]

Author: nekral-guest
Date: 2008-02-18 21:36:03 +0000 (Mon, 18 Feb 2008)
New Revision: 1848

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/NEWS
   upstream/trunk/src/groupmems.c
Log:
Fix buffer overflow when adding an user to a group. Thanks to Peter Vrabec.


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2008-02-17 17:09:42 UTC (rev 1847)
+++ upstream/trunk/ChangeLog	2008-02-18 21:36:03 UTC (rev 1848)
@@ -1,3 +1,8 @@
+2008-02-18  Nicolas François  <nicolas.francois at centraliens.net>
+
+	* NEWS, src/groupmems.c: Fix buffer overflow when adding an user
+	to a group. Thanks to Peter Vrabec.
+
 2008-02-14  Nicolas François  <nicolas.francois at centraliens.net>
 
 	* NEWS, etc/useradd: Change the default HOME directory in

Modified: upstream/trunk/NEWS
===================================================================
--- upstream/trunk/NEWS	2008-02-17 17:09:42 UTC (rev 1847)
+++ upstream/trunk/NEWS	2008-02-18 21:36:03 UTC (rev 1848)
@@ -19,6 +19,8 @@
     passwd entry, but no shadow entry.
 - groupadd
   * New option -p/--password to specify an encrypted password.
+- groupmems
+  * Fix buffer overflow when adding an user to a group. Thanks to Peter Vrabec.
 - groupmod
   * New option -p/--password to specify an encrypted password.
 - grpck

Modified: upstream/trunk/src/groupmems.c
===================================================================
--- upstream/trunk/src/groupmems.c	2008-02-17 17:09:42 UTC (rev 1847)
+++ upstream/trunk/src/groupmems.c	2008-02-18 21:36:03 UTC (rev 1848)
@@ -104,7 +104,7 @@
 		}
 	}
 
-	members = (char **) realloc (members, sizeof (char *) * i);
+	members = (char **) realloc (members, sizeof (char *) * (i+2));
 	members[i] = user;
 	members[i + 1] = NULL;
 }