[Pkg-shadow-commits] r2980 - in upstream/trunk: . src

[Nicolas FRANÇOIS]

Author: nekral-guest
Date: 2009-05-22 10:42:51 +0000 (Fri, 22 May 2009)
New Revision: 2980

Modified:
   upstream/trunk/ChangeLog
   upstream/trunk/src/usermod.c
Log:
	* src/usermod.c: Added warnings for absolute symlinks which could
	be broken by rename().


Modified: upstream/trunk/ChangeLog
===================================================================
--- upstream/trunk/ChangeLog	2009-05-22 10:41:10 UTC (rev 2979)
+++ upstream/trunk/ChangeLog	2009-05-22 10:42:51 UTC (rev 2980)
@@ -1,5 +1,10 @@
 2009-05-22  Nicolas François  <nicolas.francois at centraliens.net>
 
+	* src/usermod.c: Added warnings for absolute symlinks which could
+	be broken by rename().
+
+2009-05-22  Nicolas François  <nicolas.francois at centraliens.net>
+
 	* NEWS, src/userdel.c: Report errors to remove the user's mailbox.
 	* NEWS, src/userdel.c: When USERGROUPS_ENAB is enabled, remove the
 	user's group when the user was the only member. This is still not

Modified: upstream/trunk/src/usermod.c
===================================================================
--- upstream/trunk/src/usermod.c	2009-05-22 10:41:10 UTC (rev 2979)
+++ upstream/trunk/src/usermod.c	2009-05-22 10:42:51 UTC (rev 2980)
@@ -1412,6 +1412,9 @@
 			         Prog, user_newhome);
 			fail_exit (E_HOMEDIR);
 		} else if (rename (user_home, user_newhome) != 0) {
+			// FIXME: rename above may have broken symlinks
+			//        pointing to the user's home directory
+			//        with an absolute path.
 			if (errno == EXDEV) {
 				if (mkdir (user_newhome, sb.st_mode & 0777) != 0) {
 					fprintf (stderr,