[Pkg-shadow-devel] newusers bug - creates negative UIDs and GIDs

[Nicolas François]

Hello,


On Wed, Apr 02, 2008 at 03:54:23PM +0200, msamia at redhat.com wrote:
> 
> We got a bug report to newusers, a part of shadow-4.0.17, which is a part of 
> Red Hat Enterprise Linux 5.0. 
> (https://bugzilla.redhat.com/show_bug.cgi?id=306241)
> 
> I created a patch, which can be downloaded from our bugzilla
> (https://bugzilla.redhat.com/attachment.cgi?id=237611).
> 
> The bug is still reproducible in 4.1.0. Unfortunately, this patch can't be 
> applied to the current version of newusers. I would like to try to re-write 
> it to fit with current version, but it will not be earlier than Fedora 9 will 
> be released (lots of work on Fedora nowdays).

This should be fixed in 4.1.1, which is due for ... today.

A snapshot is available on 
ftp://pkg-shadow.alioth.debian.org/pub/pkg-shadow/snapshot/shadow-4.1.1~rc1.tar.bz2

The idea of you patch is quite similar to what is implemented in 4.1.1.
The main difference is that I wanted to reuse exactly the same
find_new_uid and find_new_gid functions in useradd and newusers (and
others).

I don't remember explicitly a test for this bug in the testsuite, but the
UID should now stick to the UID_MIN / UID_MAX range (or SYS_UID_MIN /
SYS_UID_MAX).

If Fedora 9 does not plan to include 4.1.1, applying your patch for
version 4.1.0 would be nice.

Best Regards,
-- 
Nekral