[Pkg-shadow-devel] groupmems: invalid usernames handling && segfault fix

[Nicolas François]

On Tue, Jul 22, 2008 at 11:12:51AM +0200, Lukáš Kuklínek wrote:
> Dne Tuesday 22 of July 2008 01:29:31 Nicolas François napsal(a):
> >
> > Thanks for the patch. I will probably make a few changes and check the
> > parameters earlier. Also, I would like to harmonize the error messages
> > from groupmems with the other tools.
> 
> All right, at least you know about the problem ;)
> 
> > For 455603, instead of checking if the username is valid, shouldn't we
> > check if the user exists?
> 
> Good point, I was kinda "driven" by the bugzilla entry and didn't think about 
> it much... :]. But it should be fixed just by replacing check_user_name() by 
> getpwnam(), right?

This is committed now.

By the way, as you already had a look at groupmems, I'm wondering what is
the intent of isgroup()?

I'm going to apply the attached patch to completely remove it (unless
somebody finds the original intent of isgroup().

Best Regards,
-- 
Nekral