Bug#505072: Causes FTBFS with GCC 4.4: missing #include

[Martin Michlmayr]

Package: xmltooling
Version: 1.0-2
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.4
Severity: important
Tags: patch

Your package causes other packages to fail to build with the upcoming
GCC 4.4.  Version 4.4 has not been released yet but I'm building with
a snapshot in order to find errors and give people an advance warning.

GCC 4.4 cleaned up some more C++ headers.  You always have to #include
headers directly and cannot rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable.

> Automatic build of opensaml2_2.0-1 on em64t by sbuild/amd64 0.53
...
> /bin/sh ../libtool --silent --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I. -I..   -pthread -g -Wall -O2 -O2 -DNDEBUG     -pthread -g -O2 -Wall -O2 -DNDEBUG -c -o Assertions.lo `test -f 'saml2/core/impl/Assertions.cpp' || echo './'`saml2/core/impl/Assertions.cpp
> In file included from /usr/include/xmltooling/encryption/EncryptedKeyResolver.h:26,
>                  from ../saml/encryption/EncryptedKeyResolver.h:27,
>                  from saml2/core/impl/Assertions.cpp:25:
> /usr/include/xmltooling/encryption/Encryption.h: In member function 'void xmlencryption::KeySize::setSize(int)':
> /usr/include/xmltooling/encryption/Encryption.h:47: error: 'sprintf' was not declared in this scope
> make[3]: *** [Assertions.lo] Error 1
> make[3]: Leaving directory `/build/tbm/opensaml2-2.0/saml'

--- /usr/include/xmltooling/encryption/Encryption.h~	2008-11-08 20:59:35.000000000 +0000
+++ /usr/include/xmltooling/encryption/Encryption.h	2008-11-08 21:00:08.000000000 +0000
@@ -23,6 +23,8 @@
 #if !defined(__xmltooling_encryption_h__) && !defined(XMLTOOLING_NO_XMLSEC)
 #define __xmltooling_encryption_h__
 
+#include <cstdio>
+
 #include <xmltooling/signature/KeyInfo.h>
 
 /**

-- 
Martin Michlmayr
http://www.cyrius.com/