[SCM] Debian packaging for the 2.0 Apache Shibboleth SP branch, debian, updated. upstream/2.2.1+dfsg-143-gf9647c2

Russ Allbery rra at debian.org
Wed Nov 11 01:35:04 UTC 2009


The following commit has been merged in the debian branch:
commit f9647c21285bf4f9c6f26ed2ac65f6df3b702e97
Author: Russ Allbery <rra at debian.org>
Date:   Tue Nov 10 17:34:29 2009 -0800

    Fix logic mistake in shibd as non-root user probe
    
    I introduced a logic error when refactoring the init script.  shibd -t
    doesn't return non-zero status when it can't open the private key file.

diff --git a/configs/shibd-debian.in b/configs/shibd-debian.in
index cbe55e6..c96f2d6 100644
--- a/configs/shibd-debian.in
+++ b/configs/shibd-debian.in
@@ -64,7 +64,7 @@ prepare_environment () {
     # read.  If we get that error, we fall back on running shibd as root.
     if [ -n "$DAEMON_USER" ]; then
         DIAG=$(su -s $DAEMON $DAEMON_USER -- -t $DAEMON_OPTS 2>/dev/null)
-        if [ $? != 0 ] ; then
+        if [ $? = 0 ] ; then
             # openssl errstr 200100D (hex for 33558541) says:
             # error:0200100D:system library:fopen:Permission denied
             ERROR='ERROR OpenSSL : error code: 33558541 '

-- 
Debian packaging for the 2.0 Apache Shibboleth SP



More information about the Pkg-shibboleth-devel mailing list