[Pkg-sql-ledger-discussion] New LedgerSMB Debian package, v1.3.21-1

[Robert James Clay]

On Wed, 2012-08-08 at 20:00 -0400, Robert James Clay wrote:
> On Wed, 2012-08-08 at 18:20 -0400, Raphael Hertzog wrote:
> > In control:  ....
> 
> > This change is not documented in debian/changelog. Why did you remove
> > those recommendations/suggestions ?
> 
>     That may have been the result of merge issues from 1.3.18-2 back in
> to what was then for 1.3.19-1, which I thought I had taken care of.
> I'll check it.

   That's looks to have been the cause.  I think I have it fixed and
I'll also be updating what I'm using to do the qa on the packages in
order to better check for such things.


> > In preinst:
> > 
> > +#  Set old_version variable for use later in the script.
> > +old_version=$2
> > You do not seem to use $old_version later. Drop it.
> 
>    I'll check that as well, as I thought I had a need for it (& it
> should therefore still be used)...

   The usage of that variable is intended to make that maintainer script
consistent with the others that use the information.  I'll fix it, one
way or another...





Jame