Bug#345819: subversion: README.db4.3 needs to cover ownership issues

[Ross Boylan]

On Wed, 2006-01-04 at 12:56 -0600, Peter Samuelson wrote:
> [Ross Boylan]
> > Minimally, the instructions could just say to be aware of ownership
> > and permission issues.  I know that's pretty obvious, but I managed
> > to miss it :)
> 
> I think I would have missed it too!  Here is what I've put in for the
> next upload - let me know if you think it's still insufficient.
> 
> Thanks,
> Peter
Some suggestions below.
> 
> --- README.db4.3
> +++ README.db4.3
> @@ -38,6 +38,11 @@
>  can't use "svnadmin", since it won't read BDB 4.2 environments.  You
>  can use "cp", though, e.g. "cp -a /srv/svn/repo1 /srv/svn/repo1.bak".
>  
> +Ensure that new files created will be writable by your repository
> +users: If your repository is single-user, use 'su username' if needed.
> +If it's group-writable, use 'umask 002'.  The utilities do not go to
> +any special effort to preserve existing permissions on the DB files.
> +
Instead, how about this?

Note the ownership and permissions of your existing repository files
(e.g. with 'ls -l').  The conversion utilities make no effort to
preserve ownership and permission, so you should su to the appropriate
user.  If the files are group-writable, set 'umask 002'.  Alternately,
you can use 'chown --recursive' and 'chmod --recursive' to set things
right after you have converted the database.

>  Next, make sure the repository databases are in a consistent state
>  (normally they will be, but you are about to destroy the data needed to
>  fix them if they aren't):
> @@ -81,6 +86,7 @@
>    svnadmin dump -q /srv/svn/repo1.old | svnadmin load -q /srv/svn/repo1.new
>  
>  You will also need to copy any customisations from the 'conf' and
> -'hooks' directories into the new copy of the repository.  Then, after
> +'hooks' directories into the new copy of the repository, and use
> +'chown' and 'chmod' to make the access permissions match.  Then, after
>  verifying that everything went well, you can remove /srv/svn/repo1.old
>  and rename /srv/svn/repo1.new to /srv/svn/repo1.
I'm not sure the immediately preceding discussion is necessary or
sufficient.

It may not be necessary because, if they have su'd and set masks as
indicated earlier, no special action should be needed.

It may not be sufficient, because if they haven't done so they probably
need to change settings for all the files, not just those in conf and
hooks.

Perhaps advising 'cp -a' would help, though I suspect that if you aren't
the appropriate user, or possessed of appropriate permissions, you can't
preserve owner/group.
-- 
Ross Boylan                                      wk:  (415) 514-8146
185 Berry St #5700                               ross at biostat.ucsf.edu
Dept of Epidemiology and Biostatistics           fax: (415) 514-8150
University of California, San Francisco
San Francisco, CA 94107-1739                     hm:  (415) 550-1062