[Pkg-sysvinit-devel] [PATCH 2/4] update-rc.d: Allow update-rc.d to perform actions on alternative filesystems

Kel Modderman kel at otaku42.de
Mon Jul 14 14:59:41 UTC 2008


On Tuesday 15 July 2008 00:40:36 Henrique de Moraes Holschuh wrote:
> On Tue, 15 Jul 2008, Kel Modderman wrote:
> > On Tuesday 15 July 2008 00:07:13 Henrique de Moraes Holschuh wrote:
> > > Usually, alternative initscript systems supply their own update-rc.d and
> > > invoke-rc.d.   That can be a bit more robust, although it IS a lot of code
> > > duplication.
> > > 
> > > What exactly do you intend to do with these changes to sysv-rc's
> > > update-rc.d?
> > 
> > This particular patch allows to test update-rc.d in a test suite, for example.
> > 
> > You can create /tmp/etc/init.d/, /tmp/etc/rc{S,{0..6}}.d/, put some
> > scripts in /tmp/etc/init.d/ and then manipulate runlevel links in
> > /tmp/etc/rc{S,{0..6}}.d/ by supplying /tmp as argument to -d command line
> > option.
> 
> If it is just for testing update-rc.d, I'd rather it be done using a chroot.
> That way you test the REAL effect of the command (you don't run the entire
> thing on the chroot, just the update-rc.d command itself).  That would also
> test that we have all dependencies and other such *critical* details as a
> side-effect, since we need them in the croot for update-rc.d to work ;-)

Agreed. Quality control in a chroot is the next logical step. This option
provides a programmer ability to easily script the creation of an extremely
basic environment for development of new features, which is what i used it
for when devloping patch 3 and 4 of this series. I thought I may as well share
it too.

> 
> > Maybe "alternative filesystems" was poor wording for patch description.
> 
> Yeah, and the lack of a [PATCH 0/4] introdutory email telling us what is the
> objective of the patches...

When I first learned what a patch is and how to share it, my reference was
akpm's "The perfect patch."
  <http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt>

In the document he suggests not to use the 0/N introductory email. Since I
submit patches to various projects, who use a variety of different VCS, I just
got into this habit.

> 
> Note that I am just commenting on the patches, I am not *objecting* to them.
> 

I welcome your comments very much.

Thanks, Kel.



More information about the Pkg-sysvinit-devel mailing list