<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" "http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" content="1" /><style type="text/css">p, li { white-space: pre-wrap; }</style></head><body style=" font-family:'DejaVu Sans Mono'; font-size:9pt; font-weight:400; font-style:normal;">On Saturday 30 May 2009 20:39:42 Roger Leigh wrote:<br>
&gt; &gt; Can you have a good look at [0] for errors please?<br>
&gt; &gt; <br>
&gt; &gt; [0] http://lists.alioth.debian.org/pipermail/pkg-sysvinit-commits/2009-May/001220.html<br>
&gt; <br>
&gt; It looks fine.  The only slight oddity is the slight difference in logic<br>
&gt; between checkroot.sh and postinst.  In particular, the need for<br>
&gt; <br>
&gt;   touch /etc/mtab<br>
&gt; <br>
&gt; in checkroot.sh<br>
&gt; <br>
&gt; This uses:<br>
&gt;         if [ Linux = "$KERNEL" ] &amp;&amp; [ ! -L /etc/mtab ] &amp;&amp; [ -f /proc/mounts ]<br>
&gt;         then<br>
&gt;                 if touch /etc/mtab &gt;/dev/null 2&gt;&amp;1<br>
&gt;                 then<br>
&gt;                         rm -f /etc/mtab &amp;&amp; ln -s /proc/mounts /etc/mtab<br>
&gt;                 else<br>
&gt;                         log_warning_msg "cannot symlink /etc/mtab to /proc/mounts"<br>
&gt;                 fi<br>
&gt;         fi<br>
&gt; <br>
&gt; whereas the initscripts postinst uses:<br>
&gt; <br>
&gt; if [ "$(uname -s)" = "Linux" ]<br>
&gt; then<br>
&gt;         if [ -f /etc/mtab ] &amp;&amp; [ ! -L /etc/mtab ] &amp;&amp; [ -f /proc/mounts ]<br>
&gt;         then<br>
&gt;                 rm -f /etc/mtab &amp;&amp; ln -s /proc/mounts /etc/mtab<br>
&gt;         fi<br>
&gt; fi<br>
&gt; <br>
&gt; I'm guessing here it's to cope with a read-only root on startup that the<br>
&gt; postinst doesn't need to care about.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Yeah. Is that odd? Does it need a comment?<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>Thanks, Kel.</p></body></html>