[Pkg-tcltk-devel] tDOM review & sponsorship

[Stefan Sobernig]

Sergei,

> For now:
> 0) Is 0.8.3 really necessary and why?

Well, this has been a longish discussion in OpenACS OCT, but finally
we agreed to use the unreleased CVS version as it fixes an important
UTF-8 related issue + a memory leak in threaded environments 
(=AOLServer). tDOM's changelog gives details.

> 1) There's no way to get a correct original tarball. Prefereably it
> should be made as get-orig-source target in debian/rules or precisely
> described in debian/copyright.

We will host a correctly named tarball at openacs.org and use the 
get-orig-source target. Is this acceptable to you?

> 2) Changelog mentiones 0.8.2-1 and 0.8.3-1. As they have never been
> released, it may be better to merge them to a single entry.
ok
> 3) 0.8.3 isn't a real version. It's a CVS snapshot. The version number
> should reflect that. Usually an appended date is used for that (e.g.
> 0.8.3~20080525, ~ makes this version to be less than 0.8.3).
ok ... I will do a final cvs export, create a labelled tarball, host it
and put the get-orig-source target in position.

>>>  See dpatch
>>> http://svn.debian.org/viewsvn/*checkout*/pkg-tcltk/tdom/trunk/debian/patches/shared-expat.dpatch?rev=615
>>> for details. The patch deviates a bit from the one in
>>> svn://bamboo.nes.ru/debian/tcl/tdom/trunk, namely it avoids
>>> the VPATH adjustment in Makefile.in (to allow builds with bundled expat,
>>> used as fallback strategy) and adds preprocessor conditionals for expat 1.95
>> 
>> A fallback strategy for which cases?

I planned the patches (departing from yours) to be a generic
patch that might be used by the tDOM maintainer to modify the 
distributions build system. Reverting to the internal/bundled expat 
version is of _no_ relevance to the debian source package.

//stefan