[Pkg-utopia-commits] r1334 - packages/experimental/hal/debian/patches

[Michael Biebl]

Author: biebl
Date: 2007-04-05 16:39:30 +0000 (Thu, 05 Apr 2007)
New Revision: 1334

Added:
   packages/experimental/hal/debian/patches/10_repeated_property_changed_signals.patch
Log:
The device_property_changed signal was fired twice. This patches fixes that.

http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=6538c9f78e2a3ef499c10923ecdee777d31e1fd3


Added: packages/experimental/hal/debian/patches/10_repeated_property_changed_signals.patch
===================================================================
--- packages/experimental/hal/debian/patches/10_repeated_property_changed_signals.patch	2007-04-04 13:33:10 UTC (rev 1333)
+++ packages/experimental/hal/debian/patches/10_repeated_property_changed_signals.patch	2007-04-05 16:39:30 UTC (rev 1334)
@@ -0,0 +1,43 @@
+From 6538c9f78e2a3ef499c10923ecdee777d31e1fd3 Mon Sep 17 00:00:00 2001
+From: Danny Kukawka <danny.kukawka at web.de>
+Date: Wed, 4 Apr 2007 18:48:10 -0400
+Subject: [PATCH] fix problem with repeated property-changed signals
+
+> On Mittwoch, 4. April 2007, Richard Hughes wrote:
+> > With git I'm getting the following when I remove AC:
+> >
+> > 15:56:02.865: acpi_ACAD property ac_adapter.present = false
+> > 15:56:03.041: acpi_ACAD property ac_adapter.present = false
+> > 15:56:03.048: acpi_BAT1 property battery.charge_level.percentage = 96
+> > (0x60) 15:56:03.051: acpi_BAT1 property battery.charge_level.percentage =
+> > 96 (0x60)
+> >
+> > acpi_listen seems to think that there is one event from either device,
+> > so I'm unsure what the problem is here.
+>
+> I can confirm this, I take a look at the problem. It is IMO something in
+> the acpi code, could not see this atm for other devices.
+
+This is a general problem. The signal for device_property_changed is listed
+twice in hald.c in function hald_get_gdl().
+---
+ hald/hald.c |    3 ---
+ 1 files changed, 0 insertions(+), 3 deletions(-)
+
+diff --git a/hald/hald.c b/hald/hald.c
+index 1a13a31..9135440 100644
+--- a/hald/hald.c
++++ b/hald/hald.c
+@@ -203,9 +203,6 @@ hald_get_gdl (void)
+ 				  "device_capability_added",
+ 				  G_CALLBACK (gdl_capability_added), NULL);
+ 		g_signal_connect (global_device_list,
+-				  "device_property_changed",
+-				  G_CALLBACK (gdl_property_changed), NULL);
+-		g_signal_connect (global_device_list,
+ 				  "device_lock_acquired",
+ 				  G_CALLBACK (gdl_lock_acquired), NULL);
+ 		g_signal_connect (global_device_list,
+-- 
+1.5.1
+